Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprinter shuttle update #2062

Merged

Conversation

Eagle0600
Copy link
Contributor

@Eagle0600 Eagle0600 commented Sep 23, 2024

About the PR

Replaced tiny fans with directional fans.
Named O2 and N2 ports and added decals.
Replaced medical doctor's locker with wallmount.
Added dirt where the locker used to be.
Replaced AME fuel rack with wall locker.

Why / Balance

Tiny fans create an enclosed atmosphere box that will quickly become unbreathable. Directional fans fix this problem.
Connector port changes bring the shuttle in line with other shuttles such as the Gasbender.
Wall lockers are preferred, especially for AME fuel.

How to test

Load the Sprinter and walk around. Open all the airlocks while watching the atmosphere for any sudden drops or other changes. check that two AME fuel bottles are supplied in the wall locker.

Media

Directional fans

starboarddockfans
portdockfans
evafans

Medical locker

medicallocker

Engineering

engineering

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • tweak: Retrofitted the Sprinter with directional fans and tweaked storage.

Replaced tiny fans with directional fans.
Named O2 and N2 ports and added decals.
Replaced medical doctor's locker with wallmount.
Added dirt where the locker used to be.
Fixed conflicting uids that prevented the map from loading.
Fixed rotation on two directional fans.
Moved gyroscope into engineering, using the space vacated by the fuel rack.
I missed the matching gyroscope on the other side, and the fact that the LV cables were required for the thrusters, not just the gyroscope.
@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Sep 23, 2024
@dvir001
Copy link
Contributor

dvir001 commented Sep 23, 2024

Do not rename anything, this breaks forks translation

@dvir001
Copy link
Contributor

dvir001 commented Sep 23, 2024

Remove mapped coat

@dvir001 dvir001 added Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE labels Sep 23, 2024
Removed custom named from connector ports.
Removed mapped coat.
@Eagle0600
Copy link
Contributor Author

Requested changes made and tested.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem sensible to me. Base Transform removal's interesting.

Fan placement looks good, colours seem a bit strange, but fitting enough.
Locker placement's fine, and confirmed the replacement locker has the same fill.
Seems fine overall.

@whatston3 whatston3 added Status: Needs Review This PR is awaiting reviews and removed Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE labels Sep 23, 2024
@MagnusCrowe MagnusCrowe merged commit 6cc8587 into new-frontiers-14:master Sep 23, 2024
2 checks passed
@Eagle0600
Copy link
Contributor Author

Eagle0600 commented Sep 23, 2024

Base Transform removal's interesting.

I was tired of tp coordinates not lining up with pos coordinates when loading the map. And technically it inflates the filesize for no benefit, so I saw no sense in keeping it.

colours seem a bit strange

The canister decals I added or the lights that already existed? I'm annoyed with the sodium lights but I'm not sure of the design intent behind them so I was being cautious about touching them.

@Eagle0600 Eagle0600 deleted the 2024-09-Sprinter-shuttle-update branch September 23, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants