Fix artifact analyzers to consume power only during scanning

[spacedwarf14]

About the PR

Currently artifact analyzers consume 12000W regardless of whether they are in use or not. In the YML it is commented that the intention is to only consume power during scans, but this is not the case because the APC load doesn't get updated. I think there was confusion about what apc.NeedsPower actually does, as it shouldn't affect the receiver's load (but rather, the receiver's requirement for power in the first place).

Technically wattage is set to 1 while not scanning for upstream APC bugs reasons, as @dvir001 mentioned earlier.

Why / Balance

It would certainly reduce power / fuel requirements for science ships. However the same effect is achieved by unanchoring the analyzer. Currently it's just an extra step that feels lrp.

How to test

Spawn a science ship, place artifact and scan / finish scan while monitoring power. Experiment with toggling power during scans as well to make sure pause / resume logic wasn't affected.

Media

Requirements

• I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Not a breaking change, but something I'd like to do better before this is merged: when the analyzer begins scanning, the sudden 0->12kW power draw causes apc brownout. This

1. closes the analyze console UI. not the friendliest effect.
2. Emits a PowerChanged event, which then pauses the scan, then is issued again once the APC is ramped up to resume the scan. Pausing and resume the scan doesn't call SetPowerSwitch(...) because it's actually only called when power is lost and restored, and only concerns the ActiveArtifactAnalyzerComponent. Anyway, it's kinda noisy and waste of cpu cycles.

ideas?

Changelog

🆑

• fix: Artifact analyzers do not consume power when idle

[spacedwarf14]

Maybe there's a way for a power receiver to ramp up its own consumption (just as a generator does with its supply power).

[dvir001]

Based

[Cheackraze]

the power ramping on the back end definitely leads to this, but I see it more as a shortcoming of the underlying power ramping system not being ideal.

[dvir001]

Other then the comment this is alright, just need to make sure the changed lines are marked so we can keep track in case this is changed upstream.

[whatston3]

Made a few changes for consistent commenting to Frontier changes.

Looks good, works fine under test.

[spacedwarf14]

Thanks, I will try to follow the comment convention better next time.

If this stands as it is, I want to eventually address the brownout / event spam in another pr