Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprinter atmos rework #2065

Merged
merged 9 commits into from
Oct 13, 2024
Merged

Conversation

Eagle0600
Copy link
Contributor

About the PR

Added fore and aft air alarm.
Added vent and scrubber to bar.
Linked atmos devices to air alarms.

Reevaluated shuttle price.

Changed medbay airlock to be appropriately medical.
Replaced sodium lights with fluorescent lights.

Why / Balance

Adding the air alarms and linking the devices brings the shuttle in line with current guidelines.
The shuttle's value has fallen since its last appraisal. Adding a 30% markup brings it in line with other expedition shuttles.
The medbay airlock should be properly marked.
This is a shuttle with a central bar. People are intended to be able to relax here, even if it is a bit grungy. Sodium lights run counter to this and are, frankly, annoying as a player to have ship-wide.

How to test

Purchase the Sprinter. Walk around. Play with the atmos alarms to check they function (fore alarm in engineering, aft alarm in the main hallway). Check that the vents and scrubbers all have expected gas levels after a short while to ensure they are properly connected to the distribution and waste networks.

Media

Air Alarms

airalarmaft
airalarmfore

Medbay

medbay

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Added fore and aft air alarm.
Added vent and scrubber to bar.
Linked atmos devices to air alarms.
The Sprinter is appraised at significantly less than its original price.
Medbay airlock changed to medical airlock from maintenance airlock.
Sodium lights replaced with standard fluorescent lights.
@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Sep 24, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 25, 2024
@Eagle0600
Copy link
Contributor Author

That shipyard test failure is based on the phoenix (apparently it can be sold for more than the current price), which is of no concern to this PR.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, air alarms seem well linked, YAML changes are minimal, approving, would recommend merging with a review from another pair of eyes. Will leave this open for a few days pending a separate approval, but looks good to go from my side.

For what it's worth, in-game appraisal via shipyard resale shows resale values at ~44.5k at the moment.

@ErhardSteinhauer ErhardSteinhauer merged commit 55a394d into new-frontiers-14:master Oct 13, 2024
14 checks passed
@Eagle0600 Eagle0600 deleted the sprinter branch October 20, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants