-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barge Directional Fan Update #2066
Barge Directional Fan Update #2066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Dusty!
While we're changing this, let's also replace the generator and distro pumps with their on-by-default variants. I can't push to your branch, so: https://github.com/dustylens/frontier-station-14/compare/Barge-Directional-Fan-Update...arimah:barge-directional-fans-suggestions?expand=1
Issues addressed. Let there be power. Let there not be carbon dioxide. |
…-station-14 into Barge-Directional-Fan-Update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the Barge, changes seem fine. Atmos piping still makes sense, fuel locker's good, generator starts on, pumps are started, pressures make sense.
Increased the margin to ~10% - waiting for the ship tests to pass, but this seems fine to me.
Requested changes were made earlier by Dusty.
About the PR
Updated tiny fans to directional fans.
Added fuel locker. Removed loose fuel.
Removed old atmos tank, port and pump. Replaced with updated atmos mix.
Why / Balance
There's no I in COMPLY.
How to test
Check fans. Check atmos. Check fuel locker.
Media
Requirements
Breaking changes
Changelog
🆑
tweak: updated barge with directional fans