Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barge Directional Fan Update #2066

Merged

Conversation

dustylens
Copy link
Contributor

About the PR

Updated tiny fans to directional fans.
Added fuel locker. Removed loose fuel.
Removed old atmos tank, port and pump. Replaced with updated atmos mix.

Why / Balance

There's no I in COMPLY.

How to test

Check fans. Check atmos. Check fuel locker.

Media

ss+(2024-09-23+at+10 08 11)

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

tweak: updated barge with directional fans

arimah
arimah previously requested changes Sep 27, 2024
Copy link
Contributor

@arimah arimah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Dusty!

While we're changing this, let's also replace the generator and distro pumps with their on-by-default variants. I can't push to your branch, so: https://github.com/dustylens/frontier-station-14/compare/Barge-Directional-Fan-Update...arimah:barge-directional-fans-suggestions?expand=1

@dustylens
Copy link
Contributor Author

Issues addressed. Let there be power. Let there not be carbon dioxide.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Barge, changes seem fine. Atmos piping still makes sense, fuel locker's good, generator starts on, pumps are started, pressures make sense.

Increased the margin to ~10% - waiting for the ship tests to pass, but this seems fine to me.

@whatston3 whatston3 dismissed arimah’s stale review October 11, 2024 19:53

Requested changes were made earlier by Dusty.

@whatston3 whatston3 merged commit e0254f2 into new-frontiers-14:master Oct 11, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants