Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NSF Marauder tiny fans with directional fans #2160

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

chrome-cirrus
Copy link
Contributor

@chrome-cirrus chrome-cirrus commented Oct 6, 2024

...Also added a missing one, and a couple damage control items to the atmos room per special request.

About the PR

  • Replace existing tiny fans with directional fans
  • Add a directional fan to the forward airlock with the blast door (on the inner airlock door because the blast door does some weird shit with atmos in its tile)
  • Add a holofan projector and gas analyzer to atmos distro room for damage control purposes

Why / Balance

Compliance with the tiny fan destruction edict, add a few things that make sense based on feedback in Discord

How to test

Spawn the ship in have, a walk around. No suffocation, wow! Beautiful new directional fans on every airlock, wonderful!

Media

dock1
dock2
dock3
leftengine
rightengine
request
forwardairlock
atmos

Requirements

Breaking changes

None

Changelog

🆑

  • tweak: Replaced Marauder tiny fans with directional fans. Added a fan to the forward airlock. Added some atmos tools to the atmos room.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Oct 6, 2024
@chrome-cirrus chrome-cirrus changed the title Replace NFSD Marauder tiny fans with directional fans Replace NSF Marauder tiny fans with directional fans Oct 8, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine, all directional fans accounted for.

Replaced the security signs with NFSD ones.

No strong feelings about the holofan projector, but I'll leave this open for a bit pending additional review regardless. Seems fine to me.

@ErhardSteinhauer ErhardSteinhauer merged commit e31f2f3 into new-frontiers-14:master Oct 13, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants