-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Bison #245
Adds Bison #245
Conversation
very interesting and unique ship, I'll have to give it a proper review in-game later this week because there's a lot going on but I like the idea |
Thanks for the feedback. I need to change some things about this ship in the meantime since they were pointed out to me, for example give it a protolathe/autolathe, add space cleaner for the graffiti, add a blender, and remove some lockers that were mentioned to be currently bugged (the ones in the armory). Also i need to do the change to the ship's description that you mentioned. I'll add them to the changelogs once I've updated it. |
Ok the bison has now been updated and is ready for testing. |
i dont think you understand how the changelog works it should be "added bison" not the whole history of the bison |
Those were the changes i made since the last submission when i updated it, the second "adds bison" is a mistake i made during the update. I should've called it "updated bison" or something. The changelog shows what i updated because they aren't visible in the screenshot. |
Regardless this is generally way too much for a CL for a single map (or ship in this case). It should generally be condensed into one line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be named just Bison.yml, so just drop the .txt at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your OS is hiding known file extensions, in your screenshot you can see windows reads it as a .txt file and it needs to be changed to the proper file type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your OS is hiding known file extensions, in your screenshot you can see windows reads it as a .txt file and it needs to be changed to the proper file type
ah ty
SpaceStation14.sln
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your solution file changes slipped in. Make sure to drop this file from the PR so it isn't changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure what this means here, apologies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be in the PR.
@Cheackraze Because this ship is designed as a ship-breaker, and would involve at least four players invading a derelict and breaking it apart completely for steel, components, and more (including the floor tiles), what should I replace the fire axes and hammer with so as to allow them to break apart ships? As for the axes scattered about the ship, those are strategically placed to allow people to escape the firelocks once they close, if they are trapped in those areas of the ship. Would a crowbar be able to achieve the same function of escaping locked sections if they happen to be stood there when they close? As for the armory, what would you recommend replacing the crates and vendors with to allow both mercenaries and ship breakers to do their jobs effectively? And finally, what equipment should I put in the captain's locker so that there isn't too much there? |
Axes are probably the worst tool to salvage with since it destroys the entity and won't return all the materials. Salvagers already come with all the tools they need to fully scrap a ship, namely, a full toolbelt of tools. So only one (1) fire ax OR breaching hammer allowed. Crowbars are the intended tool for opening unpowered doors.And caps locker needs a few pieces of captain drip like mantle or cape, and tools to do a job on the ship, like maybe Salvage gear for example, just not the default captain locker |
changed the generators and added more space cleaner, i forgot what else.
I jsut discovered that the lates PR has the wrong file in shipyard. i will update them. |
The Changelog on the PR still dont add up, they need to just be "Added the ship bison, description" |
changed the file names and swapped around a few minor aspects of the ship
PR should be ready to test. Hope it works out. |
removed it. BEGONE!
should be ready fr this time |
About the PR
This PR adds the Bison to the game, which is a large ship-breaking vessel designed to house 4-7 crew members comfortably, or 9-10 if you want to use the cargo bay as a makeshift camp.
Features:
drawbacks:
The lore is that this ship was a corporate-owned scrapping vessel, but the crew eventually went crazy and formed gangs that started a turf war. I was thinking that the ship is large enough that people would have families and dependents, and live full lives on the ship with cultures developing in isolation.
Media
Changelog
🆑 MatthewBadger