-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe restock #25
Safe restock #25
Conversation
Added "BaseSecuredVendingMachineRestock"
If its not working ill probably have to update VendingMachineRestockTest.cs for a bigger change. |
didnt get a chance to test yet but a quick glance looked good so far. see if i get some time tomorrow and do an in-game test just to confirm. |
lgtm but theres some merge conflicts now, just gotta resolve and submit for review we can get it in |
Done, its working as intended for now. |
since we are doing it, we really should just replace them all and make them all worth only 100 because they are all kind of just broken |
Here |
@@ -31,9 +31,15 @@ ent-CrateVendingMachineRestockRobustSoftdrinks = { ent-CrateVendingMachineRestoc | |||
ent-CrateVendingMachineRestockSalvageEquipment = { ent-CrateVendingMachineRestockSalvageEquipmentFilled } | |||
.desc = { ent-CrateVendingMachineRestockSalvageEquipmentFilled.desc } | |||
|
|||
ent-CrateVendingMachineRestockAstroVend = { ent-CrateVendingMachineRestockAstroVendFilled } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep all of our localization stuff separate, it makes it easier for translation and also avoids merge conflicts when we update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks fine, but lets keep our custom yml and ftl stuff separated in the file structure so its easier to maintain/translate. Will be good to get this in and we can lower the vending stocks a bit on some of them safely
@@ -126,6 +126,16 @@ | |||
category: Engineering | |||
group: market | |||
|
|||
- type: cargoProduct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with our own custom product entries, lets keep them separate in a new file in the _nf folder
About the PR
Added new restock type, secured.
When attempted to open by force it will destroy the refill content.
Right now its assigned to 3 new refill crates.
Astro - 1000
Circuit - 3000
Ammo - 4000
This is all still subject to change and update, the prices, labels and crate types are not final.
Changelog
🆑