Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapons from Delta-V #2527

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

FireFoxPhoenix
Copy link

@FireFoxPhoenix FireFoxPhoenix commented Dec 7, 2024

About the PR

The weapons were taken from Delta-V
Thanks to @bing268 for his help with the creation
New weapons added:

  • Mk32 “Universal”
  • Pollock
  • Fitz special
  • Faith
  • Lucky 37
  • Vulcan
  • Ceremonial rifle
  • CAWS-25 Jackdaw

Why / Balance

New weapons are created for more variety

Media

image

Changelog

  • add: Added new weapons: Mk32 "Universal", Pollock, Fitz special, Faith, Lucky 37, Vulcan, Ceremonial rifle, CAWS-25 Jackdaw

@FireFoxPhoenix FireFoxPhoenix marked this pull request as ready for review December 7, 2024 07:10
Copy link
Contributor

github-actions bot commented Dec 7, 2024

RSI Diff Bot; head commit c25f1c9 merging into ef05f0d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/Pistols/pollock.rsi

State Old New Status
base Added
bolt-open Added
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Pistols/universal.rsi

State Old New Status
base Added
bolt-open Added
equipped-BELT Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Revolvers/faith.rsi

State Old New Status
bolt-open Added
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Revolvers/fitz.rsi

State Old New Status
bolt-open Added
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Revolvers/lucky.rsi

State Old New Status
bolt-open Added
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/ceremonial_grand.rsi

State Old New Status
base Added
equipped-BACKPACK Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/jackdaw.rsi

State Old New Status
base Added
bolt-open Added
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/vulcan.rsi

State Old New Status
base Added
bolt-open Added
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added

Edit: diff updated after c25f1c9

@BlueHNT
Copy link

BlueHNT commented Dec 7, 2024

Love it.

@FireFoxPhoenix
Copy link
Author

@ErhardSteinhauer , thank you for your review. I will correct all my mistakes

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weapon names should be capitalized (consistent with upstream and our own guns).

Values are strangely high.

Unless the Jackdaw is intended to be a meme, the accuracy may need a tweak since it's wieldable.

@Radezolid
Copy link
Contributor

Unless the Jackdaw is intended to be a meme, the accuracy may need a tweak since it's wieldable.

iirc, it's a DS gun.

FireFoxPhoenix and others added 7 commits December 11, 2024 10:33
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Whatstone <[email protected]>
@FireFoxPhoenix
Copy link
Author

@whatston3 thank you.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 20, 2024
@BlueHNT
Copy link

BlueHNT commented Dec 21, 2024

Are you making the vending machine viper illegal or legal? Because it is technically a common gun that is just preferred by syndicate, even though civies can get access to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants