Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pda messaging real (DeltaV #2362) #2543

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Dec 10, 2024

About the PR

adds pda messaging

each id card gets assigned a random 4 digit number using nameidentifier system (same system used for things like mobs), this number is used as your chat id rather than anything player facing like character names

the app ui has a left panel showing all your contacts with unread indicators, and a right panel showing the current chat conversation with bubble messages like a phone app, messages show in grey for others and green for your own messages

messages are stored directly on the id card component as two dictionaries - one for recipients (storing name/job/unread status) and one for the actual message history, both sender and receiver keep full copies of conversations

to prevent metagaming the system checks if both pdas have active telecomms connection and are on same station (unless using long range radio channel), failed messages show with a red error indicator

the detective's logprobe can scan an ID card and "connect" to it, allowing them to spy on people and view their recipients and messages in real time

interesting mechanics include:

  • agent IDs can be used to impersonate others (they copy message conversation when you scan an ID, you can also change your number)
  • microwaving an id has 10% chance to wipe all messages, or randomly scramble message text and reassign conversations between contacts
  • message delivery requires working telecomms and respects radio blocking
  • notifications show truncated message previews up to 64 chars
  • contacts remember job titles from id cards (only if you message someone you dont know first)
  • messages store timestamps for rebuilding conversation order
  • supports up to 50 contacts per card
  • messages limited to 256 chars

Why / Balance

I love me some spam

How to test

DeltaV-Station/Delta-v#2362

Media

DeltaV-Station/Delta-v#2362

image

Requirements

Breaking changes

N/A

Changelog
🆑 MilonPL

  • add: Added PDA messaging!

MilonPL and others added 5 commits December 10, 2024 23:55
* the shiny new toy that breaks everything else

* privacy 😌

* janky shit

* real??

* :trollface:

* ALL HAIL DUCT TAPE SOLUTION

* FUCK

* commented every shit
Copy link
Contributor

github-actions bot commented Dec 10, 2024

RSI Diff Bot; head commit 1aa6a3a merging into e7f1ea7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Devices/cartridge.rsi

State Old New Status
cart-cri Modified
cart-mail Modified
cart-chat Added
cart-psi Added
cart-stonk Added

Resources/Textures/DeltaV/Misc/program_icons.rsi

State Old New Status
nanochat Added
stock_trading Added

Edit: diff updated after 1aa6a3a

@Cheackraze
Copy link
Member

Could you preserve the original PR notes here as well?? I know you linked them but just for preservation's sake, it would be nice to have it documented here as well

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 10, 2024

Could you preserve the original PR notes here as well?? I know you linked them but just for preservation's sake, it would be nice to have it documented here as well

Fixed

@dvir001 dvir001 requested a review from whatston3 December 10, 2024 22:51
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 10, 2024
@Cheackraze
Copy link
Member

its an interesting choice storing the data on the ID card and not onto the PDA itself. After thinking on it, it may be better this way functionally because then a criminal while incarcerated can be given a clear/empty PDA and their own ID card to still have communication rights.

@Houtblokje
Copy link
Contributor

Sending messages currently does not work between grids or while floating in space, which is a problem on frontier.

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 10, 2024

Sending messages currently does not work between grids or while floating in space, which is a problem on frontier.

Thanks for the info, should be easy to fix soon with global changes

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Dec 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants