-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inheritable Vessel and POI Prototypes #2632
Inheritable Vessel and POI Prototypes #2632
Conversation
Getting ideas to "paper": Recommending to put this to draft for now. |
Might've goofed something up, but the scaffolding's there, and it seems to work okay under very minimal tests. Things that aren't particularly related:
Diff's now closer to not adding extra lines, hooray. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine under test.
Cleaned out the Menace's IFF in-map changes.
Would like a double check that I haven't missed any ships or POIs, but this seems good.
Cook changes to the Empress' job list makes sense.
About the PR
Makes VesselPrototype and PointOfInterestPrototype inheritable.
Pushes commonly defined items in Vessel and POI prototypes into base parents.
The NFSD outpost is a slightly lighter brown for map readability, the cook role's been removed from the Empress, and engine info for the Tyne and Paladin were added.
Why / Balance
#2631 wouldn't have been needed with this.
How to test
Check Tinnia's, make sure the bus stops there (grid has StationTransitComponent) and it can't be moved (linear & angular damping in ShuttleComponent set to 999999).
Check LPBravo, make sure it's hidden.
Purchase regular ships, they should have their IFF label on and appear white.
Purchase pirate ships, they should have their IFF label off and still appear white.
Media
N/A
Requirements
Breaking changes
Existing shuttle PRs could use an update.
Changelog
Nothing player facing, no changelog.