Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambition distro/waste fix #2761

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

blackknight954
Copy link
Contributor

@blackknight954 blackknight954 commented Jan 21, 2025

About the PR

Swapped the straight pipe next to the mixer for a T pipe, attaching the mixer to the distro. Added a waste pump in thee gas can storage area near the front of the ship.

Why / Balance

Distro actually works now. You now have a way to vent your gas loop if need be, albeit youll need to flip the pump around if you want to clear the main loop

How to test

Load server,
Buy an Ambition
Look at the new changes.

Requirements

Changelog
🆑

  • fix: Fixed the distro and added a waste vent for the Ambition.

@Cu1r
Copy link
Contributor

Cu1r commented Jan 25, 2025

What was wrong with the old waste vent? You'll just catch trash on the front now. That's ironically one of the things I was specifically trying to prevent in the original design.

@blackknight954
Copy link
Contributor Author

blackknight954 commented Jan 25, 2025

What was wrong with the old waste vent? You'll just catch trash on the front now. That's ironically one of the things I was specifically trying to prevent in the original design.

nothing’s wrong with it, except it got replaced with one of the new gas airlocks, which have docking on them, just gonna restore it to how it was. Honestly I had thought you’d left frontier.

@Cu1r
Copy link
Contributor

Cu1r commented Jan 25, 2025

nothing’s wrong with it, except it got replaced with one of the new gas airlocks, which have docking on them, just gonna restore it to how it was. Honestly I had thought you’d left frontier.

Probably the best option.
I may not keep up with the community anymore due to having other projects and commitments that command my attention, but I keep up with my creations, as well as feedback on them from time to time.
I understand you're the Ambition's maintainer and I appreciate that. I just don't want to be the next Praeda.
Probably a bit overbearing and weird, but certain design choices have always been important to me. Form and function are rarely separate in my book.

@blackknight954
Copy link
Contributor Author

nothing’s wrong with it, except it got replaced with one of the new gas airlocks, which have docking on them, just gonna restore it to how it was. Honestly I had thought you’d left frontier.

Probably the best option. I may not keep up with the community anymore due to having other projects and commitments that command my attention, but I keep up with my creations, as well as feedback on them from time to time. I understand you're the Ambition's maintainer and I appreciate that. I just don't want to be the next Praeda. Probably a bit overbearing and weird, but certain design choices have always been important to me. Form and function are rarely separate in my book.

Nah that's fair, hope to see you back eventually.

@dvir001 dvir001 self-requested a review January 27, 2025 15:36
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants