Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chitinid (DeltaV #2707) #2774

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 23, 2025

About the PR

Port:
DeltaV-Station/Delta-v#2707
DeltaV-Station/Delta-v#2790
DeltaV-Station/Delta-v#2796

Chitinid, a species of ant people created as worker drones who are now their own people.

Why / Balance

Some new code for a radiation purging system that is somewhat similar to the felinid's hairball, as well as minor adjustments to the injector code to allow the species to be tagged as unable to be injected.

Media

402323526-ec0dbfa3-f6e1-4683-b61d-41974ac4e147
402323695-df218703-c99b-4866-9b52-0debe6874bc0

Requirements

Breaking changes

N/A

Changelog
🆑 ElusiveCoin, deltanedas

  • add: Added the Chitinid species, fun little glowy ant guys!
  • tweak: Felinids no longer need to use an action to eat mice, just eating them normally works.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

RSI Diff Bot; head commit 074d7b5 merging into a60cc31
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Effects/speech.rsi

State Old New Status
chitinid0 Added
chitinid1 Added
chitinid2 Added

Resources/Textures/_DV/Mobs/Customization/Chitinid/chitinid_antennas.rsi

State Old New Status
bee Added
curly Added
default Added
firefly_primary Added
firefly_secondary Added
gray Added
long Added
radar Added
short Added
slick Added
speed Added

Resources/Textures/_DV/Mobs/Customization/Chitinid/chitinid_parts.rsi

State Old New Status
charred_chest Added
charred_head Added
charred_l_arm Added
charred_l_leg Added
charred_r_arm Added
charred_r_leg Added
plated_chest Added
plated_l_arm Added
plated_r_arm Added
radiant_chest Added
radiant_head Added
radiant_l_arm Added
radiant_l_leg Added
radiant_r_arm Added
radiant_r_leg Added
spotted_chest Added
spotted_head Added
spotted_l_arm Added
spotted_l_leg Added
spotted_r_arm Added
spotted_r_leg Added
stripes_chest Added
stripes_head Added
stripes_l_arm Added
stripes_l_leg Added
stripes_r_arm Added
stripes_r_leg Added
toxic_chest Added
toxic_head Added
toxic_l_arm Added
toxic_l_leg Added
toxic_r_arm Added
toxic_r_leg Added

Resources/Textures/_DV/Mobs/Customization/Chitinid/chitinid_wings.rsi

State Old New Status
bee_primary Added
bee_secondary Added
default Added
firefly_primary Added
firefly_secondary Added
honeypot_primary Added
honeypot_secondary Added
smooth Added
stubby Added

Resources/Textures/_DV/Mobs/Species/Chitinid/parts.rsi

State Old New Status
eyes Added
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

Resources/Textures/_DV/Objects/Specific/Species/chitinid.rsi

State Old New Status
chitzite Added
chitzite_glow Added

Edit: diff updated after 074d7b5

@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 23, 2025
@MagnusCrowe
Copy link
Contributor

image

@Houtblokje
Copy link
Contributor

Don't these look too similar to mothpeople? I thought rodentia was rejected on the grounds of it being another "earth creature but humanoid", and while I do not care for rodentia, I wonder why this would not fall into the same kind of category.

I do like the fact that the benefits and debuffs make these feel unique, though I wonder if there aren't a little too much debuffs compared to the very light buffs. Especially the cold damage and hunger increase are worrisome on frontier, since food can sometimes be scarce (especially early in the round) and cold damage is literally everywhere.

I also really like how goofy their big ant butts look.

@Temoffy
Copy link
Contributor

Temoffy commented Jan 24, 2025

I'd prefer less races overall than we currently have, but I'm not sure 'too similar' applies here because we already have humans, humans but stronk with horns, and humans but short with beards.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 24, 2025

I'd prefer less races overall than we currently have, but I'm not sure 'too similar' applies here because we already have humans, humans but stronk with horns, and humans but short with beards.

This is more an issue of races missing added features.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 25, 2025

Waiting on DeltaV-Station/Delta-v#2796

@ElusiveCoin
Copy link

Waiting on DeltaV-Station/Delta-v#2796

@dvir001 It went through

ElusiveCoin and others added 5 commits January 26, 2025 00:02
…e) (new-frontiers-14#2796)

* Bug Fix +  Resistance updates + Guidebook update

Fixes the bug where they lose their light with an anom (Game limitations lets them only have one light at a time but the light returns after losing the anom)

Tweaked resistance to be a bit more tanky for the cost of weaker to elemental things like shock and harder to heal due to inability to be injected

Removed unneeded text from guidebook entry, added a more visible warning about Chitzite, fixed a spelling error, reflected more of the numerical values in the text.

* Chocolate edible
@dvir001
Copy link
Contributor Author

dvir001 commented Jan 26, 2025

@ElusiveCoin The change to move the glow to organ broken here, ill need to figure some other fix.
This PR will stay do not merge till we fix it.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Feb 2, 2025
Copy link
Contributor

github-actions bot commented Feb 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/M and removed S: Merge Conflict This PR has conflicts that prevent merging labels Feb 2, 2025
@ElusiveCoin
Copy link

@ElusiveCoin The change to move the glow to organ broken here, ill need to figure some other fix. This PR will stay do not merge till we fix it.

@dvir001 been meaning to say so the other way to fix it may be simple as well,

The organ thing was more an easy deltaV fix, the issue is when an anomaly gives you a pointlight it replaces that component on the species then deletes it when cured of the anomally

If you just make a copy of the pointlight component named something else and use that instead then the anomally wont remove it anymore, that should also allow easy future changes to their light.

@dvir001
Copy link
Contributor Author

dvir001 commented Feb 4, 2025

@ElusiveCoin The change to move the glow to organ broken here, ill need to figure some other fix. This PR will stay do not merge till we fix it.

@dvir001 been meaning to say so the other way to fix it may be simple as well,

The organ thing was more an easy deltaV fix, the issue is when an anomaly gives you a pointlight it replaces that component on the species then deletes it when cured of the anomally

If you just make a copy of the pointlight component named something else and use that instead then the anomally wont remove it anymore, that should also allow easy future changes to their light.

Im not going to fix shit and just have the Shitmed PR before honestly, we also need it for IPC anyway.

@ElusiveCoin
Copy link

@ElusiveCoin The change to move the glow to organ broken here, ill need to figure some other fix. This PR will stay do not merge till we fix it.

@dvir001 been meaning to say so the other way to fix it may be simple as well,
The organ thing was more an easy deltaV fix, the issue is when an anomaly gives you a pointlight it replaces that component on the species then deletes it when cured of the anomally
If you just make a copy of the pointlight component named something else and use that instead then the anomally wont remove it anymore, that should also allow easy future changes to their light.

Im not going to fix shit and just have the Shitmed PR before honestly, we also need it for IPC anyway.

HAHAHAHA Based, well i wish ya luck

@dvir001 dvir001 marked this pull request as draft February 4, 2025 17:27
@dvir001
Copy link
Contributor Author

dvir001 commented Feb 4, 2025

Reminder to also pull DeltaV-Station/Delta-v#2808 into this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio C# Docs Improvements or additions to documentation FTL S: DO NOT MERGE S: Needs Review This PR is awaiting reviews S: Untriaged size/M Sprites YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants