Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance #288

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Balance #288

merged 4 commits into from
Sep 19, 2023

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Sep 2, 2023

About the PR

To fix cargo sell / buy weird profits with the new cargo trade crate replacing this:

Crates that went up:
Medicinal seeds crate 500<650
Seeds crate 500<800
Bomb suit crate 650<700
Firefighting crate 1500<2800
Internals crate 500<620
Radiation protection crate 1000<1400
Slimeperson life support crate 300<400
Emergency suits crates 800<1100
Instruments Variety crate 2000<2300
Instruments Brass crate 2500<3500
FunInstruments String crate 2500<3100
Instruments Woodwind crate 2500<3000
Instruments KeyedPercussion crate 2500<3500
Water Guns crate 750<1100
Toy Box crate 900<1400

Crates that went down:
ChemistryP 850<750 (Lower to match other crates)

Items that went down:
Ame Fuel 500<400 (Item sell price change, The crate is the same price)
Ame Parts 500<400 (Item sell price change, The crate is the same price)
Body Bags 50<35 (Item sell price change, The crate is the same price)

@Cheackraze
Copy link
Member

please be more descriptive in your PR descriptions and change logs

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 3, 2023

please be more descriptive in your PR descriptions and change logs

I didn't add any since every single item on that list is a small / huge oversight on selling and buying margins, and I didn't want people going around and abusing it, regardless, I added the changes now.

Keep in mind its all intended so people will be using the trade crates instead for actual buy&sell.

@Cheackraze Cheackraze merged commit c589573 into new-frontiers-14:master Sep 19, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants