Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulpkanin Race #292

Merged
merged 29 commits into from
Sep 21, 2023
Merged

Conversation

FoxxoTrystan
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan commented Sep 4, 2023

About the PR

Add the Vulpkanin race from Delta-V as a playable race from spawn.

The Vulpkanin (vulp-ka-nin) are a race of humanoid canine-like beings.

  • Has an animal stomach.
  • Is the fastest race. (SprintSpeed: 5 / WalkSpeed: 3 / 0.5 Faster then moth)
  • Able to withstand cold environments.
  • Takes less Cold damage. (Same as moth)
  • Takes twice burn damage when on fire. (Rip Fur)
  • Get 10% more hungry.
  • Get 2.5% more thisty.
  • Has 3 Emotes. (Barks, Growls, Howls)
  • Talking Sounds. (Growls Like)
  • Lot of customizable markings.
  • Cannot speak Common Language and need a Translator to translate thier speech.
  • Vulpkanins spawn with the Translator in thier hand.
  • Vulpkanins without a translator will speak Canilunzt and only others Vulpkanins will understand them.

So far during my local test everything seem to work correctly, but take note that its my first time working with SS14.

Media

Capture2
Capture
Capture

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
  • Add Clothwarp Shoes.
  • Unique Gameplay Feature.
  • Canilunzt langauge system.

Changelog

🆑 FoxxoTrystan

  • add: The Vulpkanin race has arrived to the Frontier Sector they are a race of humanoid canine-like beings that are confortable in the cold but cannot speak common without a translator and also have their own langauge!
  • add: Cloth footwarps
  • tweak: Cloth footwarps can be found in Clothesmate
  • add: Canilunzt translator
  • tweak: Canilunzt translator can be found in Vendomat, Vulpkanins spawns with them.

FoxxoTrystan and others added 13 commits September 4, 2023 05:57
Taking more 50% damage and this make it kinda... unfair when on fire, best is to remove the "on fire" part and keep the 50%
When i added MailReceiver component, i messed up the faction component making all mobs ingore the Vulp as its has no Faction.
Me forgor "-" in damage modifier... guh!

Also now its avoid editing others files and just try to keep the files to itself so i dont mess with Space Wizard or Nayo code... hopefully.
@FoxxoTrystan
Copy link
Contributor Author

FoxxoTrystan commented Sep 8, 2023

If this PR is merged i will also work on fixing/respriting some of the Hardsuits, Masks and others clothing that does not fit due to how vulps head are.
This will be mostly made in another PR if this one is merged.

Example here:
head
(Basic Hardsuit, Salvage Hardsuit, Blood-Red Hardsuit)

@rbertoche
Copy link
Contributor

rbertoche commented Sep 11, 2023

Adding my personal take on vulpkanin/foxes, I hope it doesn't get added with speed bonus and slash damage when unarmed. They both make sense, although they make too much of a difference ingame, movement speed makes you considerably harder to hit since gunfire is slow and may also allow you to hit opponents in both melee and ranged without them having the same chance of hitting you, so having a speed bonus can't easily be balanced by other combat nerfs cause it's too powerful
About slash damage, it does make sense for claws, it's just that bleeding currently is fast steep spike, so bleeding adds up a lot of damage soon after the blow, making slash too much at an advantage against brute. But are the claws really that sharp? :P
My main reason to dislike such race features is that they make a fair unarmed fight with foxes - or felinids - impossible.

also, I saw the nice already merged colorblind commit, cool!

@FoxxoTrystan
Copy link
Contributor Author

FoxxoTrystan commented Sep 11, 2023

Regarding the felinids they have the same stats in regards of the current damage damange.
Tho indeed pehaps we could change it to 3 Piercing and 1 Blunt and change the speed to be the same as moth.

But also im very open for suggestions to balance this out in general.

Resistance, Damages, Weakness, Speed, Melee.

@FoxxoTrystan
Copy link
Contributor Author

Final Balances has been done:

  • Removed Unarmed Slash Melee (Now its has Default melee like humans)
  • Get 10% more hungry.
  • Get 2.5% more thisty.

Now all the changes will be updated in the main PR Description and i will mostly not touch anything until there changes required.

Aka, PR ready for review.

This file is kinda useless anyway and had RegisterComponent... witch should not have been there.

And also fix one tiny grammar mistake and a tiny fix.
@rbertoche
Copy link
Contributor

I think moths have same speed as humans here. I would merge this right away in my stuff if it had no walk or sprint modifier on the legs, same as felinids here.
Can I use this on Pirata? :)

@FoxxoTrystan
Copy link
Contributor Author

FoxxoTrystan commented Sep 13, 2023

I think moths have same speed as humans here. I would merge this right away in my stuff if it had no walk or sprint modifier on the legs, same as felinids here. Can I use this on Pirata? :)

Pirata? I dunno what is this this but sure.
And rechecking the code does confirm that Moth have a MovementSpeedModifier of 2.5 and 4.5 but if you wana remove it go in "Body -> Parts -> Vulpkanin" and remove the modifier there.

Tho does the MovementSpeedModifier in Ent/Species and Body/Parts are the same?

@rbertoche
Copy link
Contributor

rbertoche commented Sep 13, 2023

Pirata? I dunno what is this this but sure. And rechecking the code does confirm that Moth have a MovementSpeedModifier of 2.5 and 4.5 but if you wana remove it go in "Body -> Parts -> Vulpkanin" and remove the modifier there.

Oh you're right. I was looking at the mob's legs, it's just at the mob prototype instead.
Pirata is a ss14 code base and community and currently the most popular pt-BR server, we have foxes since it came out as a feat during april's fools upstream and also thanks! Already started a branch for adding it.

Tho does the MovementSpeedModifier in Ent/Species and Body/Parts are the same?

I have no idea, I can't even figure out what human speeds are anyway, or if those modifiers are really adding up or just assigning a new value. Anyway. I'm assuming human speed is 4 for sprint, 2 for walk? 🤷

cheers

@Cheackraze
Copy link
Member

let me know when this is ready for review

@FoxxoTrystan
Copy link
Contributor Author

let me know when this is ready for review

PR Ready for review.

@Cheackraze Cheackraze self-requested a review September 21, 2023 17:22
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, lemme test locally

@FoxxoTrystan
Copy link
Contributor Author

code looks good, lemme test locally

I am praying that everything is good and nice.

@Cheackraze Cheackraze merged commit 3ceb2b9 into new-frontiers-14:master Sep 21, 2023
14 of 17 checks passed
FrontierATC added a commit that referenced this pull request Sep 21, 2023
@FluffiestFloof
Copy link
Contributor

FluffiestFloof commented Oct 15, 2023

Would it be possible to know where the bark, growl1, growl2, growl3 and howl sound come from? They lack a license or attributions file and I'm interested in adding some of them to DeltaV.

@FoxxoTrystan
Copy link
Contributor Author

Would it be possible to know where the bark, growl1, growl2, growl3 and howl sound come from? They lack a license or attributions file and I'm interested in adding some of them to DeltaV.

Growls sounds comes from Paradise.
Barks from TG.

Il update the attributions files when i work on fixing some stuff with vulps after the upstream merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants