Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cargo teleporter tech with void jetpack #33

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Replace cargo teleporter tech with void jetpack #33

merged 2 commits into from
Jul 14, 2023

Conversation

LankLTE
Copy link
Contributor

@LankLTE LankLTE commented Jul 14, 2023

About the PR

Cargo teleporter stupid! It no work! This replaces it with void jetpack, a useful technology that does useful things
image

@Cheackraze Cheackraze self-requested a review July 14, 2023 02:54
Cheackraze
Cheackraze requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets leave any original translation files alone to both avoid merge conflicts and to keep it cleaner and easier for other translaters. we should have a _nf14 folder with the custom .ftl files in there

Cheackraze
Cheackraze reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the ftl file it looks good to go

@LankLTE
Copy link
Contributor Author

LankLTE commented Jul 14, 2023

done :)

@Cheackraze Cheackraze merged commit ebd5bd1 into new-frontiers-14:master Jul 14, 2023
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheackraze Cheackraze Cheackraze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LankLTE @Cheackraze