Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Window Placement #34

Closed
wants to merge 1 commit into from
Closed

Fixes Window Placement #34

wants to merge 1 commit into from

Conversation

LankLTE
Copy link
Contributor

@LankLTE LankLTE commented Jul 14, 2023

this is just a fix from upstream

@Elijahrane
Copy link
Contributor

Elijahrane commented Jul 14, 2023 •
edited
Loading

this is just a fix from upstream

cherry-pick the commit and submit that instead?

@LankLTE
Copy link
Contributor Author

LankLTE commented Jul 14, 2023

cherry-pick the commit and submit that instead?

im too stupid
To be serious, is it that much of a difference? It's only 8 lines so I didn't think it was a big deal but if it is for whatever reason I'll close this and do that instead

@Elijahrane
Copy link
Contributor

im too stupid To be serious, is it that much of a difference?

it preserves git history and makes it easier to maintain because then you literally have the exact same commit instead of 2 different ones

@LankLTE LankLTE closed this Jul 17, 2023
@LankLTE LankLTE deleted the glass-fix branch July 17, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LankLTE @Elijahrane