Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asteroid Vault Random Magic Book #356

Merged

Conversation

FoxxoTrystan
Copy link
Contributor

About the PR

Replace the ForceWall Magic book with a Random Magic Book Spawner (safe).

This PR change the BluespaceAsteroidVault map to replace it with a spawner.
Its also adds 2 Spawners (Magic Book Spawner) / (Magic Book Spawner Safe).

Why / Balance

Giving some randomness in the magic book would be nice and make peoples return to see what is.

Technical details

Add 2 Spawners.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

  • Added Random Magic Book Spawner.
  • Added Random Magic book Spawner (Safe).

Changelog

🆑 FoxxoTrystan

  • tweak: Added some randomness in the Asteroid Vault.

@Cheackraze Cheackraze self-requested a review October 7, 2023 18:54

- type: entity
id: RandomMagicBookSafe
name: random magic book spawner [safe]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a suffix: property for yml entities, you can set that instead and it shows up in the spawn menu like that, but in-game it loses the [safe] tag on the name when you examine it. I know tis just a spawner, but better to keep with convention

- ForceWallSpellbook
- BlinkBook
- KnockSpellbook
- FireballSpellbook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fireball is absolutely not safe by the way. fireball as a spell needs to be fixed first before its allowed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fireball spell will be moved to the "unsafe" spawner then for the moment then.

Removed "FireballSpellbook" from the safe spawner.
@Cheackraze Cheackraze merged commit c312abf into new-frontiers-14:master Oct 9, 2023
13 of 14 checks passed
FrontierATC added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants