Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specie update #524

Merged
merged 37 commits into from
Dec 1, 2023
Merged

Conversation

FoxxoTrystan
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan commented Nov 1, 2023

About the PR

Major Specie Update to make them more intresting and belanced with the new Diet system as well as changing some values, everything that is changed is listed in the document: https://docs.google.com/document/d/1mCydwEijH7GfXXed5L6qygnIjL15ZkJGz8_G7yMVJ4E/edit?usp=sharing

I also recomend to merge this PR from upstream if possible as this will assist regarding the moth Diet: space-wizards/space-station-14#21536

  • Humans
  • Vulpkanin
  • Reptilian
  • Felinid
  • Moth
  • Drawf
  • Arachnid
  • Diona
  • Slime
  • Oni
  • Size Attribute

Why / Balance

We have now a "Diet" system and so lets uses it to its fully and to balance and fixes up some species, this PR will fix some issues found aswell as demands that were waiting.

Lets makes things intresting!

Changelog
🆑 FoxxoTrystan

  • remove: Vulpkanin Speed bost (they are not default to 4.5 like all others species)
  • remove: Vulpkanin Hunger/Thrist decay has been restored to default.
  • tweak: Vulpkanin DamageModifier has been tweaked, Heat: 1.3, Cold: 0.8.
  • remove: Vulpkanin TemperatureProtection.
  • tweak: Changed Vulpkanin interaction from hugging to pats!
  • tweak: Changed Vulpkanin/Reptilian "unarmed" melee. (4 Slash, 1 Blunt)
  • tweak: Vulpkanin/Repilian Diet has been changed to only eat: "Meat, Fruits, Eggs, Bread"
  • tweak: Reptilian DamageModifier has been tweaked, Heat: 0.8.
  • tweak: Changed Felinds "unarmed" melee. (3 Slash, 2 Blunt)
  • fix: Fixed Felinds Organs (Including Diet)
  • tweak: Moth DamageModifier has been tweaked, Cold: 0.8.
  • tweak: Moth Diet has been changed to only eat: "Cloth, Fruits" (Still able to consume pills)
  • tweak: Diona war against glass shards/dices is over!
  • remove: Oni pry speed. (This is just... useless)
  • tweak: Oni Melee bonus tweaked: Stun, Blunt, Slash, Piercing, Asphyxiation: 20%
  • tweak: Oni using guns will have +20% spread.
  • add: Arachnid has now a special diet of only: "Fruits, Soup, BloodFood", meaning they can drink Bloodbags or bite others creatures for food.
  • add: Arachnid can now create cocoon that act like Straightjacket, cocoon bodies also prevent rotting!
  • add: Arachnid can now put webs on the floor that will slow non-spiders species.
  • fix: Fixed some spider web resistance from "Wood" to "Web"
  • add: Added some new craftable web furnitures/objects.
  • remove: Reverted Arachnid Melee to default (same as humans)
  • add: Short/Tall Attribute. (There a special whitelist for species meaning not all specie will have the same effect).
  • add: Gave Vulpkanins Short Whitelist, Felinds Tall Whitelist, Lizards Tall Whitelist.
  • add: New recepies for moth! (Cotton Pizza, Mothmallow, MothMoffin, CottonSoup)
  • tweak: Replaced Emercency Box Tin Food with prepacked sustenance bar (All species can eat it!)
  • tweak: Nutribrick is eatable by all species.
  • add: Custom sprites for reptilians (A jester will be happy now!)

@FoxxoTrystan FoxxoTrystan marked this pull request as ready for review November 13, 2023 19:20
Copy link
Contributor

github-actions bot commented Nov 13, 2023

RSI Diff Bot; head commit f53fc31 merging into ea97b48
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Hardsuits/syndiemedic.rsi

State Old New Status
off-equipped-HELMET-vulpkanin Added
on-equipped-HELMET-vulpkanin Added

Resources/Textures/Clothing/Mask/clown.rsi

State Old New Status
equipped-MASK-reptilian Added

Resources/Textures/Clothing/Mask/mime.rsi

State Old New Status
equipped-MASK-reptilian Added

Resources/Textures/Clothing/Mask/sadmime.rsi

State Old New Status
equipped-MASK-reptilian Added

Resources/Textures/Clothing/Mask/scaredmime.rsi

State Old New Status
equipped-MASK-reptilian Added

Resources/Textures/Clothing/Mask/sexyclown.rsi

State Old New Status
equipped-MASK-reptilian Added

Resources/Textures/Clothing/Mask/sexymime.rsi

State Old New Status
equipped-MASK-reptilian Added

Resources/Textures/Clothing/OuterClothing/Misc/webcocoon.rsi

State Old New Status
body-overlay-2 Added
cocoon Added

Resources/Textures/Nyanotrasen/Icons/verbiconfangs.rsi

State Old New Status
icon Added

Resources/Textures/Structures/Web/nest.rsi

State Old New Status
icon Added

Edit: diff updated after f53fc31

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, but theres 2 issues: 1, lizards should not be immune to miasma. Especially if we are going to bring back diseases, this makes lizards far too strong. and 2, youve changed the diets of a lot of the races but you havent updated the food prototypes themselves to include the dietary flags, so these specie are just going to starve. If you want to make another PR to accompany this one with all the food changes, then I can merge them together.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Nov 28, 2023
@FoxxoTrystan
Copy link
Contributor Author

This all looks fine, but theres 2 issues: 1, lizards should not be immune to miasma. Especially if we are going to bring back diseases, this makes lizards far too strong. and 2, youve changed the diets of a lot of the races but you havent updated the food prototypes themselves to include the dietary flags, so these specie are just going to starve. If you want to make another PR to accompany this one with all the food changes, then I can merge them together.

When looking Dietary flags seem to be there, i havent added new flags i was mostly using the existing ones.

@dvir001
Copy link
Contributor

dvir001 commented Nov 28, 2023

Make sure everyone can eat crayons.

@FoxxoTrystan
Copy link
Contributor Author

Make sure everyone cat eat crayons.

What are you? a crayon gobbler?

But sure.

@Buldinn
Copy link

Buldinn commented Nov 30, 2023

This all looks fine, but theres 2 issues: 1, lizards should not be immune to miasma. Especially if we are going to bring back diseases, this makes lizards far too strong. and 2, youve changed the diets of a lot of the races but you havent updated the food prototypes themselves to include the dietary flags, so these specie are just going to starve. If you want to make another PR to accompany this one with all the food changes, then I can merge them together.

Awwwwww maaaaaan I really really wanted lizard miasma immunity. I dont think it makes them too strong as felinids are already immune to owonavirus being felinids, unless a majority of diseases are miasma based.... It only makes sense that some species are immune to specific diseases and you could balance it by making the lizards more susceptible to other diseases....

I really dont think its too strong, I'd be willing to remove tail grabbing for it to be honest which is much stronger.

Please reconsider UWU

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this all needs to be documented on the wiki as well

@Cheackraze Cheackraze merged commit 937491e into new-frontiers-14:master Dec 1, 2023
10 of 11 checks passed
FrontierATC added a commit that referenced this pull request Dec 1, 2023
@FoxxoTrystan
Copy link
Contributor Author

ok this all needs to be documented on the wiki as well

Hmmm.... paaaain

@octowo
Copy link

octowo commented Jan 1, 2024

boss this dog scream aint it we gotta go back to the yapping board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants