Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crab (New) - Advanced salvaging shuttle #564

Conversation

RealIHaveANameOfficial
Copy link
Contributor

@RealIHaveANameOfficial RealIHaveANameOfficial commented Nov 12, 2023

About the PR

This adds the Crab, which is an advanced auto-salvaging shuttle. Rather than have to go through the manual labor of mining asteroids, now you can use the power of technology to do the hard work for you. All you have to do is collect and enjoy. With our patented Claw Grip containment system, you'll ensure no rogue asteroids evade your grasp. Tentatively priced at 50,500 spesos.

Why / Balance

Thought it was a cool idea and I'm still on my crab kick.

Technical details

The Crab has a modest medical section, a captain's quarters, a salvager's room, a bathroom, a 2 core AME, and a rudimentary atmospheric system.
The feature here are the arrays of particle emitters, all linked up to a button, with the goal of mining the hell out of any asteroid you can grab.
That leads us to the second feature, the particle containment generators. These are included to ensure any debris stays locked to where it needs to be.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: The Crab, an advanced auto-mining vessel.

@RealIHaveANameOfficial RealIHaveANameOfficial marked this pull request as ready for review November 12, 2023 15:51
@Cheackraze
Copy link
Member

i think the idea is clever, but thats a lot of emitters available on a ship and I'm concerned with it being purchased just to troll people with. It also has a ton of lighting, you should trim the amount of available lights in it

@Cheackraze
Copy link
Member

if it had maybe 4-5 emitters total i could maybe allow it

IHAN added 4 commits November 12, 2023 14:30
-Adds cameras to the mining area.
-Adds station records computer.
-Adds buttons to Captain's Quarters.
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Nov 14, 2023
IHAN and others added 3 commits November 27, 2023 03:44
-Aligns with current naming conventions
-New engineering IFF code (tentatively Eccentric Engineering Collective)
-Fixes some power connectivity issues (eventually I'll learn)
-Trims another emitter
(Did I seriously only just now add a gyro to this thing? Lol.)
@Cheackraze
Copy link
Member

remove the extra emitter crates on the top, and then theres just one small design suggestion:
crab
its too open here with this huge glass section. I suggest changing the circled part out to walls instead to help break up the sight lines and make it feel a bit more authentic and cozy inside the ship proper.

@dvir001 dvir001 added the Map-Shuttle Map - Shuttle label Dec 26, 2023
@dvir001
Copy link
Contributor

dvir001 commented Jan 24, 2024

Im moving this to draft till we can upstream merge.
you can replace the emitters with new ship miners guns after this + new ship requirements.

@dvir001 dvir001 marked this pull request as draft January 24, 2024 14:27
@dvir001 dvir001 added Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE and removed Status: Needs Review This PR is awaiting reviews labels Jan 24, 2024
@dvir001 dvir001 added the No C# label Jan 24, 2024
@dvir001 dvir001 changed the title Crab advanced salvaging shuttle Crab (New) - Advanced salvaging shuttle Jan 25, 2024
@MagnusCrowe
Copy link
Contributor

Going to close this for now. Re-open it if you wish to fix the merge issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants