Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnet #568

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Magnet #568

merged 10 commits into from
Nov 13, 2023

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Nov 12, 2023

About the PR

Code cleanup
Added magnets to all the bag belts (SO now Mail, Chems, Books bags also have magnet code)

Why / Balance

Just adding on top of the magnet system, and cleaning the code work.

Technical details

.yml
C#

Media

  • this PR does not require an ingame showcase

Breaking changes

N/A

Changelog
N/A

@RealIHaveANameOfficial
Copy link
Contributor

Does this fix the prediction/repeated collection error?

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 12, 2023

Does this fix the prediction/repeated collection error?

The visual issue?

@McBosserson
Copy link
Contributor

Magnet for generators:
Will this prevent us from unloading the fuel?

@RealIHaveANameOfficial
Copy link
Contributor

Does this fix the prediction/repeated collection error?

The visual issue?

Yeah, the issue where ore looks like it gets collected, but then reappears at its original location.

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 12, 2023

Magnet for generators: Will this prevent us from unloading the fuel?

Yes its an issue, removed it from this PR

@Cheackraze Cheackraze self-requested a review November 13, 2023 20:10
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Nov 13, 2023
@Cheackraze Cheackraze merged commit 7d9b5e9 into new-frontiers-14:master Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants