Slimes are no longer ghost roles #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-This affects all ghost role slimes but is primarily geared to stop reagent slimes from becoming ghost roles.
dvir001
reviewed
Nov 19, 2023
| makeSentient: true | ||
| name: ghost-role-information-slimes-name | ||
| description: ghost-role-information-slimes-description | ||
| - type: Speech |
dvir001
reviewed
Nov 19, 2023
dvir001
reviewed
Nov 19, 2023
| @@ -111,15 +111,6 @@ | |||
| successChance: 0.5 | |||
| interactSuccessString: petting-success-slimes | |||
| interactFailureString: petting-failure-generic | |||
| - type: ReplacementAccent | |||
| accent: slimes | |||
There was a problem hiding this comment.
Dont remove lines, uncomment then add a note # Frontier so we can keep track of changes
There was a problem hiding this comment.
Thank you, bit silly of me to simply delete it outright, in hindsight.
Cheackraze
approved these changes
Nov 22, 2023
FrontierATC
added a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Removed the ghost role components from MobAdultSlimes
Why / Balance
Reagent slimes being ghost roles is problematic, and I don't think there are any other situations where slimes are/need to be a ghost role here, so.
Breaking changes
Could affect other slime ghost roles but I don't think that will be an issue.
Changelog
🆑