Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail Rework Part 1 #610

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Nov 22, 2023

About the PR

Match closer to DeltaV code to rebase the mail system.

Changes include:

  • Open mail size 20<1
  • Moths can eat open mail (When we re add the option for moth to eat cloth it will fix itself), moth cannot eat closed mail.
  • Paper cuts damage 5<1
  • Mail receiver comp moved to automated, removed from all races.
  • Closed mail can be used in reclaimer, to destroy it on the case of too much mail (Remove lags)
  • Change the notification about open mail income to not mention income to station bank.
  • Ignore job title when opening mail, need to rework it to DNA later.

Why / Balance

Mail need some love, this is part one of a bigger rework I want to do, have to start with something.

Technical details

.yml
C#

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame,

Breaking changes

Didn't find any new issues.

Changelog
🆑 dvir01

  • tweak: Mail bags can fit more open mail.
  • tweak: Mail is now made from normal paper that isn't infused with steel, paper cuts wont hurt as much.
  • tweak: Closed mail is a bit less bulky as it used to be and will fit into reclaimers.

@dvir001 dvir001 marked this pull request as ready for review November 22, 2023 23:28
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Nov 25, 2023
@Cheackraze Cheackraze merged commit a937f6d into new-frontiers-14:master Dec 1, 2023
8 of 9 checks passed
FrontierATC added a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants