Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT Stellaris #615

Merged
merged 11 commits into from
Jan 14, 2024
Merged

NT Stellaris #615

merged 11 commits into from
Jan 14, 2024

Conversation

Lokey82
Copy link
Contributor

@Lokey82 Lokey82 commented Nov 24, 2023

About the PR

Adds the NT Stellaris, A new theatre ship.
Currently sells for 23000 spessos.
Some stuff subject to change.

Why / Balance

Technical details

Media

Stellaris - MEDIA (mapper)
Mapping view

Stellaris - MEDIA
In-game view

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Added the NT Stellaris, A new theatre ship.

@dvir001
Copy link
Contributor

dvir001 commented Nov 24, 2023

Missing plasma next to generator

(Power fix)
@Lokey82
Copy link
Contributor Author

Lokey82 commented Nov 24, 2023

Fix 002 here adds the plasma next to the generator and a RTG as the production wasn't meeting load before.
as for the shipyard file error, Nice catch!

@dvir001
Copy link
Contributor

dvir001 commented Nov 24, 2023

RTG

I think there is a rule about no RTG

@Lokey82
Copy link
Contributor Author

Lokey82 commented Nov 24, 2023

Really? I know the esquire has one

@Lokey82
Copy link
Contributor Author

Lokey82 commented Nov 24, 2023

image
If you look in engineering the Esquire does indeed have a RTG

@dvir001
Copy link
Contributor

dvir001 commented Nov 24, 2023

image If you look in engineering the Esquire does indeed have a RTG

I need to get around to removing it since people buy to scrap them off.

Lokey82 and others added 3 commits November 24, 2023 14:58
Replaces RTG with another generator
Fixed pricing
Added atmos
Added floor decor
Fixed shipyard file
@Cheackraze
Copy link
Member

i love the idea and concept of the ship but I think it could use a bit more to it, especially in the backstage area. Pics and suggestions to follow...

@Lokey82
Copy link
Contributor Author

Lokey82 commented Nov 27, 2023

i love the idea and concept of the ship but I think it could use a bit more to it, especially in the backstage area. Pics and suggestions to follow...

Yeah, I apologize for the outdated media, I made a lot of changes that did fill up the ship a bit more but didn't have time at the moment to update the media, Expect that update soon.

@Cheackraze
Copy link
Member

i love the idea and concept of the ship but I think it could use a bit more to it, especially in the backstage area. Pics and suggestions to follow...

Yeah, I apologize for the outdated media, I made a lot of changes that did fill up the ship a bit more but didn't have time at the moment to update the media, Expect that update soon.

i got you, here were my suggestions based on the original image

stellaris ship

Fixed shipyard file
Added stuff backstage
Added decals
Updated PR media
Overhauled booths
Added kitchen shutters
Moved some instruments from backstage onto stage
Removed some of the stage lights
@Lokey82
Copy link
Contributor Author

Lokey82 commented Nov 30, 2023

This should fix everything you mentioned, Also the media has been updated.

Fixed shipyard file (Again)
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix those things and this is good to merge

Resources/Prototypes/_NF/Shipyard/stellaris.yml Outdated Show resolved Hide resolved
Re-fixed shipyard file (Who knew that one capitalization error could cause so much trouble?)

Updated ship price to 45000 Spessos
@Lokey82
Copy link
Contributor Author

Lokey82 commented Dec 18, 2023

fix those things and this is good to merge

All patched up!
Please let me know if there are any more problems.

@MagnusCrowe
Copy link
Contributor

image
Color your pipes and use a standard locker, no custom fill for the captain's locker.

@MagnusCrowe
Copy link
Contributor

image
Please add wheelchair accessibility.

@MagnusCrowe
Copy link
Contributor

Add a late join spawn point.

@MagnusCrowe
Copy link
Contributor

image
Change the sec caps to regular red caps.

@dvir001 dvir001 added the Map-Shuttle Map - Shuttle label Dec 26, 2023
Replaced custom fill on captain's locker with regular captain's locker.
Fixed pipe colors.
Added 'handicap accessibility'
Redesigned stage a little to account for the accessibility.
Turned sec caps to regular red caps.
Updated PR media
@github-actions github-actions bot added the Map label Dec 29, 2023
@dvir001 dvir001 removed the Map label Jan 2, 2024
Moves files to _NF folder
Minor adjustments:
- Engineering door
- Anchor and fuel gens
- Washroom sign
- Removed DAW board
@github-actions github-actions bot added the No C# label Jan 14, 2024
@Cheackraze Cheackraze merged commit 1a2c9ba into new-frontiers-14:master Jan 14, 2024
10 of 11 checks passed
FrontierATC added a commit that referenced this pull request Jan 14, 2024
@Lokey82 Lokey82 deleted the Stellaris branch November 10, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants