Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuttle deed spawner #618

Merged
merged 24 commits into from
Dec 11, 2023
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Nov 26, 2023

About the PR

Using this spawner in a ship will spawn a card with a copy of the ship deed, to be used by admins to recover deeds of ships.

Just spawn ShuttleDeedIDCard and you will get a new card with a deed copy.

Why / Balance

Allow deed recovery.

Technical details

Added the deed component to shuttles to have the options to copy it back to a card.

Media

  • this PR does not require an ingame showcase

Breaking changes

N/A

Changelog
N/A

@Cheackraze
Copy link
Member

how safe is this? Does it break if its put on something that isnt a shuttle? What about if its put in an un-init map? or a paused map?

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Nov 26, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 26, 2023

how safe is this? Does it break if its put on something that isnt a shuttle? What about if its put in an un-init map? or a paused map?

I added a scan to to make sure its only working on shuttles, can probably add more scans to make it even more "safe"
Like scan for jobs in grid, and scan for no events to add some more filters to make sure it cannot be use on generic grids more then it was before.

@dvir001 dvir001 marked this pull request as draft November 27, 2023 00:55
@dvir001
Copy link
Contributor Author

dvir001 commented Nov 27, 2023

Moving to draft to fix and issue with multi card existing at the same time, as if one card sold the shuttle other one with the deep can bug out.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Nov 27, 2023
@dvir001 dvir001 marked this pull request as ready for review November 28, 2023 00:43
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Nov 28, 2023
@dvir001
Copy link
Contributor Author

dvir001 commented Nov 28, 2023

Fixed the issue with multi deeds, also I merged the new name change system into the code and made sure its working.

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 29, 2023

Another small issue that I need to make sure ID computer also delete deeds when there isn't a grid anymore or they going to auto eject cards, going to just copy paste the code block for it..

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 29, 2023

Another small issue that I need to make sure ID computer also delete deeds when there isn't a grid anymore or they going to auto eject cards, going to just copy paste the code block for it..

Fixed

@Cheackraze Cheackraze merged commit edaca48 into new-frontiers-14:master Dec 11, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants