Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all machine circuitboard price to return to base numbers #639

Closed
wants to merge 0 commits into from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Dec 2, 2023

About the PR

Some boards worth insane amount of money compare to what they cost

Why / Balance

Fix market issues.

We need to add a new generic boards box printing to solve entity spam the same way we did with the tech disks.

Technical details

.yml
Used vendprice to replace static for all boards, prices stay the same.

Media

  • this PR does not require an ingame showcase

Breaking changes

N/A

Changelog
N/A

@Cheackraze
Copy link
Member

why is this hardcoded vend price suddenly being added to everything again

I explicitly stated when it was added, that it was not to be used generally and only for very rare and specific things. The balance nightmare you are about to introduce by adding this everywhere is unimaginable

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 4, 2023

why is this hardcoded vend price suddenly being added to everything again

I explicitly stated when it was added, that it was not to be used generally and only for very rare and specific things. The balance nightmare you are about to introduce by adding this everywhere is unimaginable

VendPrice just set what the price of the board will be on a vending machine sell, we kinda need to do it to keep the boards using the same static price they always had since the mats cost to make them was not updated from upsteam.

As its stand right now you have people just printing protolathe boards for 800 per one!

Note this was only needed for the boards that exists on the CircuitVend

Im not sure how else to balance it without adding a full system that translate material worth to printing cost to final product worth.
This is going to take time to build something like this, so this is a good middle fix till we can do this.

@dvir001 dvir001 marked this pull request as draft December 10, 2023 17:56
@dvir001
Copy link
Contributor Author

dvir001 commented Dec 10, 2023

Redoing logic on the vendprice,
It need an actual fix for possible exploits based on price changes.
Will come back to this after,

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Dec 21, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added No C# YML and removed Merge Conflict This PR has conflicts that prevent merging labels Jan 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jan 29, 2024
@dvir001 dvir001 closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict This PR has conflicts that prevent merging No C# YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants