Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables auto-punctuation for emotes #663

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

rbertoche
Copy link
Contributor

@rbertoche rbertoche commented Dec 6, 2023

After a while playing without emotes on frontier-pt I noticed some emotes in English would still work.

Having a period at the end of emote messages prevented a lot of emotes from triggering a sound effect, because they have to match the message exactly for it to work.

Instead of making sure each and every emote has a . and ! replicate, I removed the auto punctuation for emotes.

Emotes are usually not full sentences so the period on them probably won't be missed a lot. They don't express what people are saying, so it's less likely the lack of a period impacts on meaning, attitude, tone or rhythm.

Cheers

@dvir001
Copy link
Contributor

dvir001 commented Dec 6, 2023

Before we consider this, have you looked at upstream code around this area before?
Since there been changes done to emotes and net talk that we will carry here anyway.

Also please use the PR submit format, and can you add an example of what its doing in game to talking?
Is this effecting radio? nettalk? wispers? etc.

@rbertoche
Copy link
Contributor Author

rbertoche commented Dec 9, 2023

Basically, currently frontier has auto punctuation cvar enabled by default, which simply breaks most emotes which don't have a corresponding hardcoded replacement containing a dot at the end.
I don't think I have a screenshot of that though. You simply say @yell and it fails after auto punctuation is applied because there is no replacement for "yell." declared.
I have no idea what upstream is doing chat wise, I usually mostly only read their code when I am merging or after I merge it. This is not meant to replace their code or actually be a fork, unless they don't fix the issue upstream.
The idea was, emotes were broken in current frontier when you build and run locally, it's an easy fix, so I made a PR.

This only affects emotes. Emotes are no longer affected by auto punctuation. Sorry, I thought my descriptions were enough to make it clear what is happening. I simply made emotes bypass auto punctiation.

@rbertoche
Copy link
Contributor Author

If the changes to net talk you are referring to are acronyms replacements such as omg -> oh my god, without a sound effect, they are already present on current frontier and don't conflict or bring any issues.

@Cheackraze Cheackraze self-requested a review December 10, 2023 17:51
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 10, 2023
@Cheackraze Cheackraze merged commit 271b66c into new-frontiers-14:master Dec 10, 2023
9 of 10 checks passed
@dvir001
Copy link
Contributor

dvir001 commented Apr 27, 2024

This update made it super hard to support DeltaV emotes as every single time we match them up we are getting issues with it, reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants