VendPrice Rework #680
Merged
VendPrice Rework #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheackraze
approved these changes
Dec 21, 2023
|
Paper is back |
Cheackraze
approved these changes
Dec 23, 2023
dvir001
added a commit
to dvir001/frontier-station-14
that referenced
this pull request
Jan 7, 2024
Cheackraze
pushed a commit
that referenced
this pull request
Jan 14, 2024
* Vender * Music * Update vending_machine_restock.yml * AutoTune * Price * Update base_instruments.yml * PR #680 was a waste of time ... * Cant add static to this Be sci, build dew`s, sell dew`s dew money meta. * Update frontier.yml * Update frontier.yml * Update vending_machines.yml * Added 4 tiles next to bus area * Update autotunevend.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
The VendPrice comp no longer has the final say.
The vending will try to use it but if
StaticPrice * modifieris equal or higherVendPriceis ignored.Why / Balance
This was a logic mistake on my part since upstream updates can screw pricing by mistake and add a vend abuse.
This change make the
VendCompnone effective in the case of logic price issue.Technical details
c#
VendComp will not be an issue for
StaticPricebut now used for preferred price.Media
N/A
Breaking changes
N/A
Changelog
N/A