Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vend change #69

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Vend change #69

merged 3 commits into from
Jul 23, 2023

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jul 22, 2023

About the PR

The action to eject machine items is disabled,
Multitool, EMP, Player controlled or damage to vend machines will not drop any items.
Machines worth is now static of 1000 and will ignore any content in it.

@ghost
Copy link

ghost commented Jul 22, 2023

first of all, PR 69, nice

second of all, selling sectechs for 17k is one of the best pieces of exped loot, pls reconsider!

@sTiKyt
Copy link
Contributor

sTiKyt commented Jul 22, 2023

But why? It makes sense for machine to drop some items when you break it

@dvir001
Copy link
Contributor Author

dvir001 commented Jul 22, 2023

But why? It makes sense for machine to drop some items when you break it

Not when some items cost 75k
This is a temp fix to a bigger issue, we can go back and re do this function to some machines later.

@sTiKyt
Copy link
Contributor

sTiKyt commented Jul 22, 2023

But why? It makes sense for machine to drop some items when you break it

Not when some items cost 75k This is a temp fix to a bigger issue, we can go back and re do this function to some machines later.

Let's just fix that specific item? I'm working on some price rebalancing rn as well, we could team up a bit and figure it out

@dvir001
Copy link
Contributor Author

dvir001 commented Jul 22, 2023

But why? It makes sense for machine to drop some items when you break it

Not when some items cost 75k This is a temp fix to a bigger issue, we can go back and re do this function to some machines later.

Let's just fix that specific item? I'm working on some price rebalancing rn as well, we could team up a bit and figure it out

Its every single machine, and it need bigger changes, you can start making the changes and PR it later.
This PR only un-comment few lines related to abuse that is going around as we speak, and it can be reverted ones all machines had changes to allow stopping of free items.

@sTiKyt
Copy link
Contributor

sTiKyt commented Jul 22, 2023

But why? It makes sense for machine to drop some items when you break it

Not when some items cost 75k This is a temp fix to a bigger issue, we can go back and re do this function to some machines later.

Let's just fix that specific item? I'm working on some price rebalancing rn as well, we could team up a bit and figure it out

Its every single machine, and it need bigger changes, you can start making the changes and PR it later.
This PR only un-comment few lines related to abuse that is going around as we speak, and it can be reverted ones all machines had changes to allow stopping of free items.

Makes total sense to me, understood

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok for now but not ideal. In the end, if you could remove the eject on wire pulse and player controlled eject but leave in the eject on damage. last I tested, you can only get 2-3 items to eject until the vending machine is 'broken' and so I think that's still kind of funny behavior that's ok

@Cheackraze Cheackraze merged commit 12862c2 into new-frontiers-14:master Jul 23, 2023
@dvir001 dvir001 deleted the Vend-Change branch July 23, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants