Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back to RepDrobe some det clothing which some users used as drip #690

Closed

Conversation

rbertoche
Copy link
Contributor

@rbertoche rbertoche commented Dec 13, 2023

About the PR

It adds back some clothing items removed from the rep drobe. According to comments in the yml they were removed due to being detective clothes.

Why / Balance

These clothes in my opinion, beyond having "Detective" in their prototype ID - which the users don't see - were both good options for players roleplaying a reporter/journalist/writer whatever and for people who used the RepDrobe purely for drip. That drobe is present in the Waveshot and now it only has one single suit option. I don't think the name of the prototype matters a lot in terms of which clothing should be present where. The actual names of the clothing aren't strictly tied to the role: They're named "noir suit" and "hard-worn suit" in game.

I have kept the removal of the detective vest from that drobe which really didn't make much sense, maybe it was left there along with the other detective stuff by accident, I guess.

It's just 2 jumpsuits and 2 jumpskirts, both versions of noir suit and hard-worn suit.

And the necktie.

Technical details

No changes but adding back the missing items from that drobe.

Media

image
image

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, having those will be nice, its not like its illegal to have Detective/Security/Military looking clothes, we have merc that look like sec, ect...

So ye those look nice!

@dvir001
Copy link
Contributor

dvir001 commented Dec 13, 2023

The name of the protototypes is 100% why they were removed

For administrative and map makers it's shows up and raises questions

If you want them back do as the note and REPLACE them with new ptototypes

@dvir001 dvir001 mentioned this pull request Dec 13, 2023
@dvir001 dvir001 mentioned this pull request Dec 25, 2023
@dvir001 dvir001 added the Duplicate This issue or pull request already exists label Jan 2, 2024
@dvir001
Copy link
Contributor

dvir001 commented Jan 7, 2024

Fixed on #758

@dvir001 dvir001 closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants