Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectre #699

Merged
merged 30 commits into from
Dec 22, 2023
Merged

Spectre #699

merged 30 commits into from
Dec 22, 2023

Conversation

Wolfhauler
Copy link
Contributor

@Wolfhauler Wolfhauler commented Dec 14, 2023

About the PR

Added the Spectre, a science mothership that is meant to be crewed mainly by scientists. This ship is meant to be segmented and easily able to lose its science wings without all being lost. This ship is also meant to be flown in a fleet of salvage, medical, and food ships.

Why / Balance

Technical details

Media

Spectre

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@YumiGumi
Copy link
Contributor

you uploaded the wrong file for the shipyard file, it's just another copy of the ship rather than the proper yml

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple issues without loading/testing the PR File.

• frontier-station-14.wsp? this file should not be here.
• Shipyard file... not the correct file... at all, check how others Shipyards files has been done.
• Externals walls need to be reinforced. (Walls that are between space and the ship)
• Missing Grill under windows. (Are those even normal windows?)
• AME not powred on init.
• Ship seem extremly emtpy, i recomend to fill it up with more objects/decals.

Also holy hell the number of thusters?
Anywho your ship seem good in design but extremly emtpy, make the rooms more intresting.

@Wolfhauler
Copy link
Contributor Author

got told it needed more thrusters, guess they where wrong. also musta brain deaded the file just got home from a long shift before doing the file management. reinforced?. il add the grilles and look at the AME. Also will look at adding a few more things but it is meant to accomadate the anomaly gen well so not to much

@Wolfhauler
Copy link
Contributor Author

New image added to reflect updated ship

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 16, 2023
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Design overall is correct but i have a bunch of changes and recomendation:

Changes Requested:
• Some Thrusters are not correctly connected and so unpowred, make sure there are connected to an LV Cable.
• MV Cables under thrusters is useless, please remove them.
• You should use Random Drink Spawner in the bar instead of fixed drink, this can cause issues on map spawn when there Upstream updates.
• Remove the SH at at the start of your ship name as those was removed to avoid loong names.

Recomendation:
• Grid appraised at 80183, the price you proposed is EXTREMLY high compair to this.
• Replace CE by a simple Engineer.

@Wolfhauler
Copy link
Contributor Author

Copy will fix after shift

@Wolfhauler
Copy link
Contributor Author

Wolfhauler commented Dec 17, 2023

fixed everything you mentioned, picture now does not reflect the ship. Priced it at 95k

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

• Some thrusters are just unconnected.
• Theres random MV Cables/Pipes inside the walls (use the command "mappingclientsidesetup" to see all pipes correctly.
• MV Cables are still a mess, normally MV calbes should connect only to APCs (or others machiens that only need MV Cables but most need LV)

@FoxxoTrystan FoxxoTrystan mentioned this pull request Dec 18, 2023
1 task
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could make the 2 docks into full 2 stage airlocks, double the price, and maybe spruce up a bit of the areas with some more purple science decals, and this looks good to go.

id: Spectre
name: Spectre
description: A large research mothership designed to be flown nexto a small fleet of other ships including salvage and food services.
price: 95000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the anomaly spawner should be adding like 75k minimum to this price point. Since this is a special case thsed, and the potentiais ship to be so science-focused, and the potential for abuse of anomalies, please make this ship valued closer to 200k.

@Cheackraze
Copy link
Member

oh i see a new pr, i commented on the wrong one hah.

The Design overall is correct but i have a bunch of changes and recomendation:

Changes Requested: • Some Thrusters are not correctly connected and so unpowred, make sure there are connected to an LV Cable. • MV Cables under thrusters is useless, please remove them. • You should use Random Drink Spawner in the bar instead of fixed drink, this can cause issues on map spawn when there Upstream updates. • Remove the SH at at the start of your ship name as those was removed to avoid loong names.

Recomendation: • Grid appraised at 80183, the price you proposed is EXTREMLY high compair to this. • Replace CE by a simple Engineer.

the high price is because it has an anomaly generator. I dont want those to be cheap or easy to obtain, so we should have this thing be rediculously expensive to try to run.

@Cheackraze
Copy link
Member

Trystan brought up good stuff too, i didnt fully load this one to test because I had some fundamental design requests

@Wolfhauler
Copy link
Contributor Author

All will be fixed in a few hours and PR then will be updated, didnt know there was a command to see wires in walls lol

@Wolfhauler
Copy link
Contributor Author

all fixed PR image updated

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seem perfect, Good job!

@Wolfhauler
Copy link
Contributor Author

Thanks for your patience with me!

@Cheackraze
Copy link
Member

no syndicate fireaxes please. 1 regular one is fine. Also, no crematoriums, as they are more often just used to grief people. Along with that, they are kind of indestructible and a bit jank at the moment. After those changes this should be ready to merge.

@Wolfhauler
Copy link
Contributor Author

no syndicate fireaxes please. 1 regular one is fine. Also, no crematoriums, as they are more often just used to grief people. Along with that, they are kind of indestructible and a bit jank at the moment. After those changes this should be ready to merge.

oh sorry thought it was the regular fireaxe, and sure crem was for removing unwanted artis but not needed

@Cheackraze
Copy link
Member

no syndicate fireaxes please. 1 regular one is fine. Also, no crematoriums, as they are more often just used to grief people. Along with that, they are kind of indestructible and a bit jank at the moment. After those changes this should be ready to merge.

oh sorry thought it was the regular fireaxe, and sure crem was for removing unwanted artis but not needed

does....does that work? Huh

@Cheackraze Cheackraze merged commit 9018c22 into new-frontiers-14:master Dec 22, 2023
8 of 9 checks passed
FrontierATC added a commit that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants