Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add McCargo ship #702

Merged
merged 21 commits into from
Dec 21, 2023
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Dec 15, 2023

About the PR

The McCargo from DarinCorp is now allowing anyone to own their very own McCargo franchisee!
Full restaurant, equipped with a storage area, freezer, kitchen, restrooms, janitor room and food court.

Make it your own! sell fast food like never before!
Coming with 4 docks, you can even buy another ship to make delivers right from your restaurants with a small faster ship.

Price to sell is on the 61700~ range
So the price to buy is set to 75000

Medium size class.

Why / Balance

No fast food ship existed.

Technical details

.yml

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame,

Spawned:
image

Editor:
image

Breaking changes

N/A

Changelog
🆑 dvir01

  • add: Added the McCargo ship, get your very own McCargo franchisee today!

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 15, 2023

Small change to add shutters to front area, one defibrillator cabinet next to it so save people from heart attacks.
Linking the firelock a bit more to the alarm

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-Reinforced wall for the external wall?
That is extremly risky and normally all ships should have the hull reinforced.

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 16, 2023

Non-Reinforced wall for the external wall? That is extremly risky and normally all ships should have the hull reinforced.

Updated with some more changes

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 18, 2023
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general il give it the thumb of approval due that its looking like a good ship (And yes i saw the updated version on discord)

Generally, nice job; just finish was check ask and have his approval!

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 18, 2023

Updated again with discord requests

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

floorings a bit booring but I'll allow it

@Cheackraze Cheackraze merged commit 1bd8f50 into new-frontiers-14:master Dec 21, 2023
8 of 9 checks passed
FrontierATC added a commit that referenced this pull request Dec 21, 2023
@dvir001
Copy link
Contributor Author

dvir001 commented Dec 21, 2023

floorings a bit booring but I'll allow it

Fair,
Ill rework it soon to make it more fun after we doing the new gun safes. (That also need alot of fix work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants