Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barge Update #772

Merged
merged 7 commits into from
Jan 7, 2024
Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

About the PR

Updated Barge:

  • Added waste loop, mapped emergency lights.

Why / Balance

To curb CO2 build up.

Technical details

.yml changes

Media

2023-12-27_11 44 56

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog
🆑 erhardsteinhauer

  • tweak: Tweaked Barge - added waste loop to atmos.

@TsjipTsjip
Copy link
Contributor

YML-wise, this PR is too complex to review by hand. I'll load this in-game in a bit.

Copy link
Contributor

@TsjipTsjip TsjipTsjip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things, the rest looks good to go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a commit from a different PR and should be removed from this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk how to "re-base" (or "re-master", hell, I don't even know the proper term for this) the commit. Can make new one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used google, re-based this branch to my master

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scrubber should be moved away from the wast piping itself for clarity, analogous to the vent in the same room.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@github-actions github-actions bot added Map-Shuttle Map - Shuttle Map labels Dec 28, 2023
@MagnusCrowe MagnusCrowe self-requested a review December 29, 2023 01:02
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 29, 2023
@dvir001 dvir001 removed the Map label Jan 2, 2024
@MagnusCrowe MagnusCrowe merged commit 676dcb6 into new-frontiers-14:master Jan 7, 2024
10 of 11 checks passed
FrontierATC added a commit that referenced this pull request Jan 7, 2024
@ErhardSteinhauer ErhardSteinhauer deleted the barge-upd branch January 31, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants