Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honker Update #774

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

About the PR

Updated Barge:

  • Added atmos setup, mapped emergency lights.

Why / Balance

To curb CO2 build up.

Technical details

.yml changes

Media

2023-12-27_11 44 01

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog
🆑 erhardsteinhauer

  • tweak: Tweaked Honker - added atmos setup.

@TsjipTsjip
Copy link
Contributor

Is there a passive vent underneath the top right thruster for waste egress?

Rest looks good to me.

@ErhardSteinhauer
Copy link
Contributor Author

Aye, passive vent is under thruster.

@TsjipTsjip
Copy link
Contributor

This feels.... very very cursed to the point that I would go as far as to ask for it to be moved, as I do not think it is possible in-game to re-anchor the thruster on top of it if you unanchor it.

@ErhardSteinhauer
Copy link
Contributor Author

I'll check if it prevents anchoring thruster.
Also clown ship is cursed as a concept in general.

@TsjipTsjip
Copy link
Contributor

Fair, I was just told it works by @dvir001 , so this looks fine. There's a clown PDA in the locker that was not added in this PR that should be removed (because it gives an ID card), and the nitrous oxide should also probably be removed. Could you roll that into this PR? Rest looks good to me.

@ErhardSteinhauer
Copy link
Contributor Author

Fair, I was just told it works by @dvir001 , so this looks fine. There's a clown PDA in the locker that was not added in this PR that should be removed (because it gives an ID card), and the nitrous oxide should also probably be removed. Could you roll that into this PR? Rest looks good to me.

Actually I believe all (like all 5) of those lockers are custom. Do we have clown-specific lockers/vendors? I don't have nearly enough hours as clown to know what one needs for power clowning.

@dvir001
Copy link
Contributor

dvir001 commented Dec 27, 2023

Fair, I was just told it works by @dvir001 , so this looks fine. There's a clown PDA in the locker that was not added in this PR that should be removed (because it gives an ID card), and the nitrous oxide should also probably be removed. Could you roll that into this PR? Rest looks good to me.

Actually I believe all (like all 5) of those lockers are custom. Do we have clown-specific lockers/vendors? I don't have nearly enough hours as clown to know what one needs for power clowning.

Clown lockers were added from upstream but were missing this update for now,
The lockers are ok for now but need just the pda removed.

Cloth vender (the one with jester cloth) will have clown gear on it soon, so you can add it.

@ErhardSteinhauer
Copy link
Contributor Author

Removed PDA, replaced one locker with AutoDrobe

@MagnusCrowe MagnusCrowe self-requested a review December 29, 2023 01:14
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 29, 2023
@MagnusCrowe MagnusCrowe merged commit 8ce819c into new-frontiers-14:master Dec 29, 2023
9 of 10 checks passed
FrontierATC added a commit that referenced this pull request Dec 29, 2023
@ErhardSteinhauer ErhardSteinhauer deleted the honker-upd branch January 31, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants