Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector (New) - Small salvage shuttle #783

Closed
wants to merge 4 commits into from

Conversation

UbaserB
Copy link
Contributor

@UbaserB UbaserB commented Dec 29, 2023

About the PR

I noticed that people REALLY like small salvage ships. Sometimes, i get to see 3-6 prospectors and pioneers. Instead of getting a huge number of the same type of ship, I feel it would be better to increase the number of options instead. This ship presents a cousin to the pioneer, made for solo salvage but slightly bigger so you can haul a lot of supplies from debris and asteroids efficiently.

It features quadruple thrusters for fast acceleration, and a compact design at the front so it uses less space. Near the rear end there is a large lattice field for storing supplies; to sell, or keep.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image
image

Changelog

🆑 Ubaser

  • add: The NC Collector is a new solo salvage ship made for quick trips to and from debris, albeit bigger than the Pioneer.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle Map labels Dec 29, 2023
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stacked Thrusters is a BIG NO.
They must face space or unused tile.
(This is a bug currently and may get fixed soonish)

mapname should have the "NC" removed, as this should be only visible on the shipyard and not the IFF.

Also your atmos is looking... wired, may need to have changes.

@UbaserB UbaserB changed the title NC Collector NC-Collector Dec 29, 2023
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recomendation still:

Put a wrench or wrench the air tank on init.

@UbaserB
Copy link
Contributor Author

UbaserB commented Dec 29, 2023

Recomendation still:

Put a wrench or wrench the air tank on init.

wrench spawns in salv closet

@dvir001 dvir001 removed the Map label Jan 2, 2024
@Cheackraze
Copy link
Member

its cute and I like it but the only thing is its just into the small category and should have the full 2 stage airlock if possible

@dvir001 dvir001 added the Status: Awaiting Changes This PR has changes that need to be made before merging label Jan 25, 2024
@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews and removed Status: Awaiting Changes This PR has changes that need to be made before merging labels Jan 25, 2024
@dvir001 dvir001 changed the title NC-Collector Collector (New) - Small salvage shuttle Jan 25, 2024
@dvir001
Copy link
Contributor

dvir001 commented Feb 7, 2024

Is this ship still getting worked on?
Please update the ship with the new guide lines and the requested changes if it is.
https://frontierstation14.com/index.php/Ship_Submission_Guidelines

@dvir001 dvir001 added Status: Awaiting Changes This PR has changes that need to be made before merging and removed Status: Needs Review This PR is awaiting reviews labels Feb 7, 2024
@dvir001 dvir001 marked this pull request as draft February 7, 2024 14:36
@UbaserB
Copy link
Contributor Author

UbaserB commented Feb 7, 2024

Is this ship still getting worked on?
Please update the ship with the new guide lines and the requested changes if it is.
https://frontierstation14.com/index.php/Ship_Submission_Guidelines

yes it is, i wasn’t informed about this before so i was simply waiting for a review. Thank you!

@GreaseMonk
Copy link
Contributor

We just dm'ed on discord, let me know if you need help anyways. some more points:

  • No posters on window in between docking airlocks
  • No pump needed for waste line
  • Pump needed for distro line i think?
  • well yeah and the two stage airlock
  • needs at least one defib and fire extinguisher
  • replace pacman with the one that has the [Ship] tag
  • havent loaded the map in to check, but check if it has a warp point ship and latejoin spawn point(s)

@GreaseMonk
Copy link
Contributor

@UbaserB Closing this for now due to it being opened last year and gone stale again now.
Please mention any [at]maintainer in discord to reopen this, or if you need any further help.

@GreaseMonk GreaseMonk closed this Mar 25, 2024
@UbaserB
Copy link
Contributor Author

UbaserB commented Mar 25, 2024

i keep forgetting about it, i will probably end up making a new separate PR when i do the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Awaiting Changes This PR has changes that need to be made before merging YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants