Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC Kilderkin - bar/brewery ship #791

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Dec 30, 2023

About the PR

"Spaceworthy bar/microbrewery with everything one needs to facilitate poor life choices: lots of booze, smokes, and lack of food.", - Shipyard.
Ship size: Medium (264 tiles)
Recommended crew: 3
Cost: 42900
Power Gen Type: Plasma
Expeditions: No
IFF Console: No
Available Roles: Bartender, Botanist, Mercenary, Pilot

Why / Balance

Dedicated bar ship. NSFD better start their printer for tickets for drunken driving.

Technical details

.ymls

Media

2024-1-22_20 55 15
2024-1-22_20 56 40

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog
🆑 erhardsteinhauer

  • add: Added NC Kilderkin - bar/brewery ship.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle Map labels Dec 30, 2023
Copy link
Contributor

@TsjipTsjip TsjipTsjip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facts:

  • Ship price at shipyard: 42900
  • Ship sale value at shipyard: 38754

Minor notes:

  • Musician's corner is a bit dark. Moody tho, could argue keeping it like this.

This ship is a good example of a bar ship that is quite literally nothing else except for a little bit of botany, but it does not have a kitchen which keeps it true to its name. I see no issues with this ship as of now.

@ErhardSteinhauer
Copy link
Contributor Author

Facts:

  • Ship price at shipyard: 42900
  • Ship sale value at shipyard: 38754

I think I went for 10% markup.

Minor notes:

  • Musician's corner is a bit dark. Moody tho, could argue keeping it like this.

There is a lamp in that corner for those who'd like more light.

This ship is a good example of a bar ship that is quite literally nothing else except for a little bit of botany, but it does not have a kitchen which keeps it true to its name. I see no issues with this ship as of now.

Debated if I even should have botany there, but some cocktails require fruits or veggies.

@dvir001
Copy link
Contributor

dvir001 commented Dec 30, 2023

Ship mark up need to be 6% up to 15%
I think McCargo is 15%
Loader is 7%
And so on

@ErhardSteinhauer
Copy link
Contributor Author

Facts:

  • Ship price at shipyard: 42900
  • Ship sale value at shipyard: 38754

Wait, do you mean despite me adding 10% markup it sells without one?

@dvir001 dvir001 removed Map labels Jan 2, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 2, 2024
@ErhardSteinhauer
Copy link
Contributor Author

Fixed shipyard file for the ship.

@github-actions github-actions bot removed the YML label Jan 5, 2024
@Cheackraze
Copy link
Member

lgtm. The engi locker is a little sus but as long as its not a hard suit locker, this looks just fine. I'm also ok with it having only a 10% markup since there isnt really anything on the ship to make it like, some kind of money printing ship.

@ErhardSteinhauer
Copy link
Contributor Author

I think it's just engilocker without the hardsuit (hence the emergency wall locker in the same room). It's mostly there for looks. And for filled utility belt.

@ErhardSteinhauer
Copy link
Contributor Author

ErhardSteinhauer commented Jan 22, 2024

Updated the ship to current standards and updated the images in PR:

  • Enabled Pilot Job.
  • Replaced Engineer Locker with Utility Belt [Filled]
  • Replaced Emergency EVA Wall Closet with Suit Wallstorage Unit (EVA).
  • Swapped some consoles for tabletop versions.

@MagnusCrowe
Copy link
Contributor

Updated the ship to current standards and updated the images in PR:

  • Enabled Pilot Job.
  • Replaced Engineer Locker with Utility Belt [Filled]
  • Replaced Emergency EVA Wall Closet with Suit Wallstorage Unit (EVA).
  • Swapped some consoles for tabletop versions.

Are you sure? I just loaded it up and the pilot job isn't on the records computer.

Ship looks good. I need to check with Checkraze about the camera server though, I'll get back to you.

@ErhardSteinhauer
Copy link
Contributor Author

I'm fairly sure, yeah.
2024-1-23_08 08 57

@MagnusCrowe
Copy link
Contributor

I'm fairly sure, yeah.

Wild, I could have sworn I only saw 3 options last time I booted it up. I see it now...I must be going insane.

No issues with the camera server. Will probably be approving it today.

@MagnusCrowe MagnusCrowe merged commit 306de7d into new-frontiers-14:master Jan 24, 2024
10 of 11 checks passed
FrontierATC added a commit that referenced this pull request Jan 24, 2024
@ErhardSteinhauer ErhardSteinhauer deleted the Kilderkin branch January 31, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants