Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crime Assist pda program (DeltaV) #801

Closed
wants to merge 0 commits into from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Dec 31, 2023

About the PR

Add a Crime Assist program, which helps NFSD and Lawyer players determine what crime was committed without having to have a wiki open.

Why / Balance

For many players, evidently, reading up on Space Law is an insurmountable obstacle, and as a result they have trouble identifying what is and isn't a crime. For this reason, a PDA program that gives a basic way to see what sort of crime was committed may help.

Technical details

The PDA program is fairly simple. It has a ew buttons (Start, Home, Yes, No) which are visible/invisible depending on the program's State. This State also determines which Localization string is displayed.

The laws are based on DeltaV and will need changes done for Frontier to be fully working.

Media

DeltaV-Station/Delta-v#464

Breaking changes

N/A

Changelog
🆑 dvir01

  • add: Added the Crime Assist program to Security and Lawyer PDA's, to help identify a crime with a simple yes/no question tree.

Copy link
Contributor

github-actions bot commented Dec 31, 2023

RSI Diff Bot; head commit d813411 merging into 79dfed4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Icons/cri.rsi

State Old New Status
cri Added

Resources/Textures/DeltaV/Objects/Devices/cartridge.rsi

State Old New Status
cart-cri Added

Edit: diff updated after d813411

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 31, 2023

This is fully working, but using DeltaV laws right now
Ill need someone to help fix the yml to Frontier space law.

@dvir001 dvir001 added the Help Wanted Extra attention is needed label Jan 2, 2024
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jan 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Sprites YML C# UI FTL and removed Merge Conflict This PR has conflicts that prevent merging labels Jan 14, 2024
@Timfa2112
Copy link

Great to see my little program make its way to Frontier! If you need any help figuring out how the yaml works, feel free to send me a message on Discord (timfa)

@@ -44,15 +44,25 @@

- type: entity
parent: BasePDA
id: GuardPDA
name: guard PDA
id: PrisonGuardPDA
Copy link

@Timfa2112 Timfa2112 Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to revert this change; the PrisonGuardPDA is a DeltaV thing. I'm pretty sure this entire role doesn't exist in Frontier.

Copy link
Contributor Author

@dvir001 dvir001 Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont worry im adding it to fix it.
Right now this PR is in waiting for Frontier space law rewrite.

@dvir001 dvir001 marked this pull request as draft January 26, 2024 23:25
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Help Wanted Extra attention is needed Merge Conflict This PR has conflicts that prevent merging Sprites UI YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants