Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds station guard uniform jumpsuit and skirt #803

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

MagnusCrowe
Copy link
Contributor

About the PR

Adds a uniform for a station guard officer. It can be found in the uniform printer with the rest of the uniforms. I left it out of the secdrobe because it is not an official security position.

Why / Balance

We may want to add a station guard and I was struck by inspiration to create a uniform for them.

Technical details

Uniform costs 3 pieces of cloth in the uniform printer like the other jumpsuits/jumpskirts.

Media

image

image

image

image
Monkey get's a piece of the drip too.

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 MagnusCrowe

  • add: Added station guard jumpsuit and jumpskirt.

Copy link
Contributor

github-actions bot commented Jan 1, 2024

RSI Diff Bot; head commit 815ff08 merging into 7e8f3b4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Uniforms/Jumpskirt/security_stationguard.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Uniforms/Jumpsuit/security_stationguard.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 815ff08

@MagnusCrowe MagnusCrowe added the Enhancement New feature or request label Jan 1, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 1, 2024
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter happy, files goods.

Good job! and im thinking if we should have a Station Guard Job.
But that to debate.

@dvir001
Copy link
Contributor

dvir001 commented Jan 1, 2024

Linter happy, files goods.

Good job! and im thinking if we should have a Station Guard Job. But that to debate.

Honestly we can just add it, if feedback is bad just remove it from the list and call it a day.
No issues with giving it a go.

@FoxxoTrystan
Copy link
Contributor

Linter happy, files goods.
Good job! and im thinking if we should have a Station Guard Job. But that to debate.

Honestly we can just add it, if feedback is bad just remove it from the list and call it a day. No issues with giving it a go.

True that.

@Buldinn
Copy link

Buldinn commented Jan 1, 2024

Looking forward to being station security in style

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@dvir001 dvir001 merged commit 8090412 into new-frontiers-14:master Jan 1, 2024
11 of 12 checks passed
FrontierATC added a commit that referenced this pull request Jan 1, 2024
@MagnusCrowe MagnusCrowe deleted the station-guard-uniforms branch January 16, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants