Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McCargo Changes #804

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 1, 2024

About the PR

Updated the tables, added a lock toggle for the back door area to stop people from running into back room storage,
Moved the cow away from the freezer to make sure its not eating the monkey meat.
Updated the AME area look.
Added mirrors in restroom area
Replaced the safe with empty new safe for captain.
Update decals next to entry area

Technical details

Mapping changes

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame,

image

Breaking changes

N/A

Changelog
N/A

@github-actions github-actions bot added the Map label Jan 1, 2024
@dvir001 dvir001 marked this pull request as draft January 1, 2024 15:18
@dvir001 dvir001 added Map-Shuttle Map - Shuttle and removed Map labels Jan 2, 2024
@github-actions github-actions bot added the No C# label Jan 4, 2024
@dvir001 dvir001 marked this pull request as ready for review January 4, 2024 23:41
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 4, 2024
@MagnusCrowe
Copy link
Contributor

MagnusCrowe commented Jan 5, 2024

image
For whatever reason, shutters and blast doors will not close over opaque airlock doors but they will over glass airlock doors. Something you might want to consider when using this type of layout.
You might want to change this to bolt the door instead of having a shutter on it.
Same for the door on the other side of the kitchen.

@ErhardSteinhauer
Copy link
Contributor

You might want to change this to bolt the door instead of having a shutter on it.

Would like to point out small quirk with this proposition: bolting doors is instantaneous whereas shutter closing animation takes a bit of time, so it's possible to desynchronize door bolts with shutters if you aren't careful with that button.

@MagnusCrowe
Copy link
Contributor

You might want to change this to bolt the door instead of having a shutter on it.

Would like to point out small quirk with this proposition: bolting doors is instantaneous whereas shutter closing animation takes a bit of time, so it's possible to desynchronize door bolts with shutters if you aren't careful with that button.

Fact.

@MagnusCrowe MagnusCrowe self-requested a review January 5, 2024 07:13
@MagnusCrowe
Copy link
Contributor

MagnusCrowe commented Jan 5, 2024

Other than the weird door stuff that you may or may not want to fix, I approve. Just let me know if you're not going to fix it and I'll merge this.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 5, 2024

Other than the weird door stuff that you may or may not want to fix, I approve. Just let me know if you're not going to fix it and I'll merge this.

Its doing bolt and shutter, its intended when upstream fix this issue.
Its fine.

@MagnusCrowe MagnusCrowe merged commit 814a04a into new-frontiers-14:master Jan 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants