Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DEMAG #824

Merged
merged 23 commits into from
Feb 12, 2024
Merged

The DEMAG #824

merged 23 commits into from
Feb 12, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 4, 2024

About the PR

Added the DEMAG to allow fixing vending machine, doors and lockers.
More to be added later, but for now just the critical stuff.

Why / Balance

We had to destroy vending machines before since there was no way to fix them.

Technical details

C#
YML

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame,

Breaking changes

N/A

Changelog
🆑 dvir01

  • add: NT Now provide the SR and Sheriff with the new DEMAG cryptographic resequencer, currently allowing them to unhack vending machines, doors and lockers with more to come soon.

@GentleButter
Copy link

GentleButter commented Jan 4, 2024

demag
DEMAG

Copy link
Contributor

github-actions bot commented Jan 4, 2024

RSI Diff Bot; head commit 688c797 merging into fb086e7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Tools/demag.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 688c797

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 4, 2024
@Everturning
Copy link

where is it obtained from?

@GentleButter
Copy link

where is it obtained from?

I beleive it spawns on the Sheriff and SR just like the door configurator and the door access emotes

@dvir001 dvir001 changed the title Demag The DEMAG Jan 7, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Jan 7, 2024

DEMAG Now works with doors and lockers.

@TheShuEd
Copy link
Contributor

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 11, 2024

space-wizards/space-station-14#23097

Yooo thats fucking cool

Whlle having this as a tech and one time use per key wont 100% fit the frontier style, this has alot of the code work done that I wanted to make for this

Also we have the DoorSystem code done and I will love to share it if it will help in that PR

For now to not waste time on more code ill wait a bit and see how this upstream PR goes and reuse the code later

Keep In mind for frontier use our version is ready for now.

@Tornado-Technology
Copy link
Contributor

space-wizards/space-station-14#23097

Yooo thats fucking cool

Whlle having this as a tech and one time use per key wont 100% fit the frontier style, this has alot of the code work done that I wanted to make for this

Also we have the DoorSystem code done and I will love to share it if it will help in that PR

For now to not waste time on more code ill wait a bit and see how this upstream PR goes and reuse the code later

Keep In mind for frontier use our version is ready for now.

There is an Advanced key that is not wasted, but in general you can use DeemagComponent.

@Cheackraze
Copy link
Member

id say we keep this pr open or in draft mode until more movement is made on the upstream one, and then we can customize it for here and either add or augment whatever functionality its missing. I'm thinking of removing it from the sci tech tree and putting them in sec fabs as 1 time door fixers or something, but very nice to see both applications tbh

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Feb 10, 2024
@Cheackraze Cheackraze merged commit b1e9547 into new-frontiers-14:master Feb 12, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants