-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dungeons (Update) #829
Dungeons (Update) #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont move upstream files here please, keep upstream files where they belong, this will just make merging upstream a nightmare.
Im fine with leaving files on the upstream folder but wont it be more easy to just let the upstream ones go there and our to stay on _NF since we have balance changes on them, so we dont mess with our custom ones? I can also just make a "copy" of the files and leave them in the original folders and the new _NF if its fine with you. |
because if you move upstream files, git is going to re-add them when I do a merge and then the game is going to crash when it tries to load duplicate yml prototypes and then I have to spend time figuring out why and where and for what reason we have duplicates. Its a nightmare, so dont move upstream files please |
I got the original current files from upstream, and made sure the ones were using keep to a new format name, let me know if this fix is fine. |
No need anymore |
About the PR
Moved all dungeon files to _NF to not be mixed with upstream, except the upstream ones.
Upgraded all files to v6 except templates
Nothing changes in the dungeons files other them moving and upgrades.
Why / Balance
Groundworks for future edits, after that ill be redoing rewards and then layout updates with new content.
Technical details
Mapping
Media
N/A
Breaking changes
N/A
Changelog
N/A