Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suit Wallstorage Unit #831

Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

About the PR

Wall-mounted child of Suit Storage Unit complete with pre-filled variants.

Why / Balance

Having more wall-mount entities might help to utilize space on smaller ships more efficiently.

Technical details

.yml

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Breaking changes

Shouldn't be

Changelog
🆑 erhardsteinhauer

  • add: Added wall-mounted suit storage units.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

RSI Diff Bot; head commit 9a085c3 merging into ca4997a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Storage/suit_storage_wall.rsi

State Old New Status
generic Added
generic_door Added
generic_open Added
locked Added
panel Added
slot_jetpack Added
slot_suit Added
slot_tank Added
unlocked Added
welded Added

Edit: diff updated after 9a085c3

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seem to work, nicly working, but i feel you could use just "WallLocker" as a parent instead, but both works.

@ErhardSteinhauer
Copy link
Contributor Author

Couple times seen on discord that suit charging might become a thing. Don't know the deets but I'm assuming that suits are going to charged in Suit Storage Units, so I wanted to make this one compatible "from the box" so to say.

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit of clean up to use multi parents to make it simple to support later

@dvir001 dvir001 merged commit 6a8b2a3 into new-frontiers-14:master Jan 6, 2024
11 of 12 checks passed
FrontierATC added a commit that referenced this pull request Jan 6, 2024
@ErhardSteinhauer ErhardSteinhauer deleted the Suit-Storage-Unit-Wallmount branch January 31, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants