Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabletop Computer Terminals #854

Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

About the PR

Tabletop variants of all existing in the base SS14 and Frontier computer terminals.

Why / Balance / Discussion

A way to create smooth-looking bridges to ships. Or cubicles to torture office workers on Space Stations.
I'm not sure if I should include Frontier specific consoles, so lemme know what are your thoughts on that one.

Technical details

  • .yml with multiple parenting.
  • Avoiding creating multiple copies of existing .png-files for terminal displays and keyboards so the graphics is handled by specifying path to Structures/Machines/computers.rsi for the bits that require that.

Media

image
image

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Breaking changes

Shouldn't be

Changelog
🆑 erhardsteinhauer

  • add: Added tabletop variants to common computer consoles. Available for mappers right now.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

RSI Diff Bot; head commit 5c19252 merging into 0277223
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Machines/computer_tabletop.rsi

State Old New Status
broken_tabletop Added
computer_tabletop Added
generic_keyboard_tabletop Added

Edit: diff updated after 5c19252

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@dvir001 dvir001 merged commit 8326936 into new-frontiers-14:master Jan 9, 2024
12 of 13 checks passed
FrontierATC added a commit that referenced this pull request Jan 9, 2024
@ErhardSteinhauer ErhardSteinhauer deleted the Tabletop-Computers branch January 31, 2024 05:58
@Aexxie
Copy link
Contributor

Aexxie commented Feb 7, 2024

Hey there's some wacky offset issue in your second screenshot w/ the power monitor

Look at the screen, and how it is being rendered above the frame.

@ErhardSteinhauer
Copy link
Contributor Author

Hey there's some wacky offset issue in your second screenshot w/ the power monitor

Look at the screen, and how it is being rendered above the frame.

Thanks for bringing it up. Shouldn't be hard to fix. Also it's not power monitor, but solar control. Weirdly enough it actually upstream issue. But shouldn't be hard to fix anyways.
image

@Aexxie
Copy link
Contributor

Aexxie commented Feb 7, 2024

Whoops. Always get those mixed up despite my hundreds of hours in engineering.

Oddd, I never realized that happened on the standard computers either..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants