Salvage Fix #86
Merged
Salvage Fix #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Reverts sub biomes for now. they seem to be re-structuring how entities are spawned and hence ore veins specifically are being spawned on top of things still. While the idea of multi-biome planet maps is totally awesome, our bite-sized adventures already introduce multi-biome gameplay at our fingertips and play seems to be focused around the immediate area of the dungeon and shuttle anyways, so I doubt players will actually notice this.
The intention is to either wait until upstream can fix whatever recursion actually happened or eventually re-introduce the landing pad method and bring back the sub biomes after that.