Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diona Tags Fix #868

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 11, 2024

About the PR

Remove tags from diona to help keep accidental tags missing in the case upstream adds new tags and we forgot to update it down to diona.

Added a new small comp by the same name of ShoesRequiredStepTriggerImmune to diona

Why / Balance

This update has no changes to diona other then removing the ShoesRequiredStepTriggerImmune tag from it and adding it back as a small comp

Technical details

The original tag stay the same, this is just so we can clear the tags from diona.

Media

N/A

Breaking changes

N/A
Diona stay the same for this update.

Changelog
N/A

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take note that borgs also uses that tag, but also coming from upstream.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 12, 2024

Take note that borgs also uses that tag, but also coming from upstream.

In the case of borgs no need to change anyhing, its just to make sure diona keep the tags without issues.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 25, 2024
@dvir001 dvir001 marked this pull request as ready for review January 25, 2024 00:07
@Cheackraze Cheackraze merged commit cdc595d into new-frontiers-14:master Jan 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants