VendingPriceModReplacer Refactor #872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
YML
C#
UI
Status: Needs Review
|
Doing a change to just make it use the existing code as to not add any new calcs |
|
Done, not adding new calcs, just allow a change to vend mod per item. |
github-actions
bot
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
Merge Conflict
github-actions
bot
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Need a rewrite of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Remove VendPrice comp, replace it with a new float under StaticPrice.
Make it replace the vending mod per item.
Static * modifier.Mod
without VendingPriceModStatic * VendingPriceModReplacer
When VendingPriceModReplacer exists and its higher then VendingPriceMod.Why / Balance
Allow setting a mod multi per item, this cannot be used to lower vending mod, only increase it.
Technical details
C# for code replacements
yml for the items that were using old comp
Media
N/A
Breaking changes
Removed
VendPricecompReplaced it with the new
vendingPriceModReplaceron theStaticPricecompChangelog
N/A