-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USS Mayflower Bug Fixs #879
USS Mayflower Bug Fixs #879
Conversation
looks good, but in your change log, be sure you are specifying that those changes are being done to this specific ship. It would be confusing and pretty much incorrect to players reading the changelog. |
I clarify it now in the changelog part |
Made changes to keep with guidelines with tsjiptsjip approving it live on stream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes at current state are sane.
Why are you changing the Name template? |
USS makes the name on radar scans too long. No other ships have this either. |
That doesn't make sense. SIL, KC and all the other ships have Name templates like that |
Correct, and this change does not touch that at all. Map name template is used for the name a ship gets on radar, not in the shipyard. |
Yes thats the point. The Orginal Mayflower name is The HMS Mayflower. Which was use during the actual time of the Mayflower. I Change it to USS because of how significant that was in American history. Removing that is removing part of the value and understanding of the name |
Please find me a template that also have the radar line with the prefix and ill go and fix it. |
About the PR
Fix the Locker Problems that I was told about but couldn't see on my end. Until after Players during a round showed me what MagnusCrowe experiencing. Also, remove the 45 ammo and speedloaders that I accidentally left.
Why / Balance
Couldn't open Wall lockers. Change to standard lockers and 45 ammo wasn't posted to be on the final edition
Media
Changelog
🆑