Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USS Mayflower Bug Fixs #879

Merged
merged 2 commits into from
Jan 14, 2024
Merged

USS Mayflower Bug Fixs #879

merged 2 commits into from
Jan 14, 2024

Conversation

VividPups
Copy link
Contributor

@VividPups VividPups commented Jan 13, 2024

About the PR

Fix the Locker Problems that I was told about but couldn't see on my end. Until after Players during a round showed me what MagnusCrowe experiencing. Also, remove the 45 ammo and speedloaders that I accidentally left.

Why / Balance

Couldn't open Wall lockers. Change to standard lockers and 45 ammo wasn't posted to be on the final edition

Media

image

  • I have added screenshots/videos to this PR showcasing its changes in-game

Changelog
🆑

  • tweak: Mayflower - Replaced wall-mounted lockers of the Merc and Prisoner with regular ones, removed loose .45 cal ammo and speedloaders.

@Cheackraze
Copy link
Member

looks good, but in your change log, be sure you are specifying that those changes are being done to this specific ship. It would be confusing and pretty much incorrect to players reading the changelog.

@VividPups
Copy link
Contributor Author

I clarify it now in the changelog part

@github-actions github-actions bot added Map-Shuttle Map - Shuttle and removed YML labels Jan 14, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 14, 2024
@dvir001
Copy link
Contributor

dvir001 commented Jan 14, 2024

Made changes to keep with guidelines with tsjiptsjip approving it live on stream.

@dvir001 dvir001 self-requested a review January 14, 2024 14:08
Copy link
Contributor

@TsjipTsjip TsjipTsjip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes at current state are sane.

@VividPups
Copy link
Contributor Author

Why are you changing the Name template?

@TsjipTsjip
Copy link
Contributor

Why are you changing the Name template?

USS makes the name on radar scans too long. No other ships have this either.

@VividPups
Copy link
Contributor Author

That doesn't make sense. SIL, KC and all the other ships have Name templates like that

@TsjipTsjip
Copy link
Contributor

That doesn't make sense. SIL, KC and all the other ships have Name templates like that

Correct, and this change does not touch that at all. Map name template is used for the name a ship gets on radar, not in the shipyard.

@VividPups
Copy link
Contributor Author

Yes thats the point. The Orginal Mayflower name is The HMS Mayflower. Which was use during the actual time of the Mayflower. I Change it to USS because of how significant that was in American history. Removing that is removing part of the value and understanding of the name

@dvir001
Copy link
Contributor

dvir001 commented Jan 14, 2024

That doesn't make sense. SIL, KC and all the other ships have Name templates like that

Please find me a template that also have the radar line with the prefix and ill go and fix it.

@MagnusCrowe MagnusCrowe merged commit 24efc9a into new-frontiers-14:master Jan 14, 2024
12 of 13 checks passed
FrontierATC added a commit that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants