Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS #883

Merged
merged 11 commits into from
Feb 15, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 14, 2024

About the PR

Added the start of the CODEOWNERS file.

@github-actions github-actions bot added the No C# label Jan 14, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 14, 2024
@FoxxoTrystan
Copy link
Contributor

Explain this file please.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 14, 2024

Explain this file please.

It auto assign this:
image

.github/CODEOWNERS.txt Outdated Show resolved Hide resolved
@FoxxoTrystan
Copy link
Contributor

When this is aproved i may add some of my shuttles/code on it.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 14, 2024

When this is aproved i may add some of my shuttles/code on it.

You can just send me the edit your want on Discord so I can quick add it

@dvir001 dvir001 marked this pull request as draft January 14, 2024 15:46
@dvir001
Copy link
Contributor Author

dvir001 commented Jan 14, 2024

Note this file is based on #863 with changes under the upstream uncommitted lines for the sake of no merge conflicts.

@dvir001 dvir001 marked this pull request as ready for review January 24, 2024 13:36
@dvir001
Copy link
Contributor Author

dvir001 commented Jan 24, 2024

We can really start using this for ships, I made sure this file wont have conflicts issue with the one coming from upsteam merge.

# Bluespace Events
/Resources/Maps/_NF/Bluespace/asteroidbunker.yml @MagnusCrowe @FoxxoTrystan
/Resources/Maps/_NF/Bluespace/asteroidvault.yml @MagnusCrowe @FoxxoTrystan

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the bluespace event map cargoina ship

@Cheackraze Cheackraze merged commit 2f08293 into new-frontiers-14:master Feb 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants