Goblin Species #890

ErhardSteinhauer · 2024-01-19T08:44:58Z

About the PR

New species: Goblins.
New accent: Goblin Cant - cockney + rogue cant (apparently it's secret rogue language from 1800s).
Goblinkind banner.
Food Quality System was moved to different PR: Food Quality System (Goblin) #1159

Why / Balance

To make the common saying "maint goblin" a lot more literal.
And because goblins are cool.

Technical details

Takes 10% more damage from brute (blunt, slash, piercing).
Takes 20% less poison damage.
Deal reduced amount of slashing damage in unarmed melee.
Smaller and lighter than dwarfs or felinids.
Datasets for name generation.
Sounds (filled out attributions and license files, outlined changes to the original files as well).
Moderate customization options: ears, noses and tusks.
Goblins can jump into mail units and toilets

Media

I have added screenshots/videos to this PR showcasing its changes ingame.

Breaking changes

There are some changes done to meat.yml in the base SS14.

Changelog
🆑 erhardsteinhauer

add: Added new species - Goblins.
add: Added new accent - Goblins Cant.
add: Added new decoration piece - Goblinkind Banner.

github-actions · 2024-01-19T08:45:36Z

RSI Diff Bot; head commit c0f7d90 merging into d30add9
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Mobs/Customization/goblin_ears.rsi

State	Old	New	Status
goblin_ears_default			Added
goblin_ears_default_alt			Added
goblin_ears_long_01			Added
goblin_ears_long_02			Added

Resources/Textures/_NF/Mobs/Customization/goblin_noses.rsi

State	Old	New	Status
goblin_nose_crooked			Added
goblin_nose_default			Added
goblin_nose_long			Added

Resources/Textures/_NF/Mobs/Customization/goblin_tusks.rsi

State	Old	New	Status
goblin_tusks_big			Added
goblin_tusks_none			Added
goblin_tusks_small			Added

Resources/Textures/_NF/Mobs/Species/Goblin/organs.rsi

State	Old	New	Status
appendix-inflamed			Added
appendix			Added
brain-inhand-left			Added
brain-inhand-right			Added
brain			Added
ears			Added
eyeball-l			Added
eyeball-r			Added
heart-off			Added
heart-on			Added
kidney-l			Added
kidney-r			Added
liver			Added
lung-l			Added
lung-r			Added
muscle			Added
nerve			Added
stomach			Added
tongue			Added
vessel			Added

Resources/Textures/_NF/Mobs/Species/Goblin/parts.rsi

State	Old	New	Status
eyes			Added
full			Added
head_f			Added
head_m			Added
l_arm			Added
l_foot			Added
l_hand			Added
l_leg			Added
r_arm			Added
r_foot			Added
r_hand			Added
r_leg			Added
torso_f			Added
torso_m			Added

Resources/Textures/_NF/Structures/Decoration/banner.rsi

State	Old	New	Status
banner_goblin			Added

Edit: diff updated after c0f7d90

ErhardSteinhauer · 2024-01-19T08:55:28Z

YAML Linter flags files I didn't even touched in my PR. I assume that this problem was carried from master.

ErhardSteinhauer · 2024-01-19T09:16:30Z

Oh, I fixed it: I restored the lines I deleted by mistake in speech_emote_sounds.yml.

Resources/Prototypes/_NF/Entities/Mobs/Species/goblin.yml

FoxxoTrystan

Code wise its seem fine.

But what unique to they bring?
A unique feature of them?

Resources/Prototypes/_NF/Entities/Mobs/Species/goblin.yml

ErhardSteinhauer · 2024-01-19T09:37:49Z

Code wise its seem fine.

But what unique to they bring? A unique feature of them?

So right now it's just visual diversity. But there are planned features for them however those require more knowledge on my part or roping in someone with c# skills.

lowered slashing damage to 3, upped fixture radius to 0.3

FoxxoTrystan · 2024-01-19T09:40:22Z

Code wise its seem fine.
But what unique to they bring? A unique feature of them?

So right now it's just visual diversity. But there are planned features for them however those require more knowledge on my part or roping in someone with c# skills.

Checkraze is fine adding new species but wishes that they have unique features and not a copy of others species.

Vulps was langauge (rework PR is pending)
Vox is oxygen = bad.
ect...

ErhardSteinhauer · 2024-01-19T09:45:47Z

Code wise its seem fine.
But what unique to they bring? A unique feature of them?

So right now it's just visual diversity. But there are planned features for them however those require more knowledge on my part or roping in someone with c# skills.

Checkraze is fine adding new species but wishes that they have unique features and not a copy of others species.

Vulps was langauge (rework PR is pending) Vox is oxygen = bad. ect...

Well, I have two ideas for goblins that I don't know how to implement right now:

Make so they can eat only spoiled and rotten food stuffs: don't get poison from spoiled foods but get poison from normal stuff.
Give them the ability to scratch tiles (basically infinite gray colored crayon).

Wolfking6116 · 2024-01-19T10:28:26Z

Having an animal stomach is already somewhat unique, as it's already pre-coded to open up some more options for diet. Personally I am already very excited to be a spess goblin

FoxxoTrystan · 2024-01-19T11:19:30Z

Having an animal stomach is already somewhat unique, as it's already pre-coded to open up some more options for diet. Personally I am already very excited to be a spess goblin

Vulps, Moth, Lizard, Felinds has animal stomach.

Resources/Prototypes/_NF/Entities/Mobs/Species/goblin.yml

…immune to rotten meat damage

ErhardSteinhauer · 2024-01-19T12:40:58Z

Code wise its seem fine.
But what unique to they bring? A unique feature of them?

So right now it's just visual diversity. But there are planned features for them however those require more knowledge on my part or roping in someone with c# skills.

Checkraze is fine adding new species but wishes that they have unique features and not a copy of others species.
Vulps was langauge (rework PR is pending) Vox is oxygen = bad. ect...

Well, I have two ideas for goblins that I don't know how to implement right now:

Make so they can eat only spoiled and rotten food stuffs: don't get poison from spoiled foods but get poison from normal stuff.

Give them the ability to scratch tiles (basically infinite gray colored crayon).

Mkay, made so that goblins don't get poisoned from eating rotten meat. As the matter of fact, goblins heal a marginal amount of toxin and brute by eating rotten or goblin meat, so if you're a goblin be wary of goblins near you. I count that as a species gimmick. But I will think how I can improve upon it over time.

ErhardSteinhauer · 2024-01-19T15:25:04Z

Code wise its seem fine.
But what unique to they bring? A unique feature of them?

So right now it's just visual diversity. But there are planned features for them however those require more knowledge on my part or roping in someone with c# skills.

Checkraze is fine adding new species but wishes that they have unique features and not a copy of others species.
Vulps was langauge (rework PR is pending) Vox is oxygen = bad. ect...

Well, I have two ideas for goblins that I don't know how to implement right now:

Make so they can eat only spoiled and rotten food stuffs: don't get poison from spoiled foods but get poison from normal stuff.

Give them the ability to scratch tiles (basically infinite gray colored crayon).

Mkay, made so that goblins don't get poisoned from eating rotten meat. As the matter of fact, goblins heal a marginal amount of toxin and brute by eating rotten or goblin meat, so if you're a goblin be wary of goblins near you. I count that as a species gimmick. But I will think how I can improve upon it over time.

Also cooked food (anything that somehow gets that Flavorol reagent attached to it) is now poisonous for goblins, so don't eat at McCargo (well, unless they are willing to fix you up with some of that rotten meat they stockpile near the toilets).

GentleButter · 2024-01-19T16:11:40Z

WOOOOO LETS DO THIS

github-actions · 2024-04-20T00:52:57Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…rs-14#884) * Adds howling / growling noises * revenge of the spelling error!! grahh!! * trying to fix that error with the schema validator * Fixing copyright + adds vulp growls to harpy emote * The case of the missing attributions dashes. * Fixes up attributions.yml with license.txt info * Update Resources/Audio/DeltaV/Voice/Vulpkanin/attributions.yml Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Adeinitas <[email protected]> --------- Signed-off-by: Adeinitas <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]>

dvir001

Im going to gabble gabble

ErhardSteinhauer added 4 commits January 19, 2024 08:17

base

97800ae

more customization options

5729946

ability to pilot, animal stomach, ai faction

d0af6b4

small adjustment to dmg mods

6cb1490

github-actions bot added Sprites YML C# FTL labels Jan 19, 2024

fix to attributions.yml

45d1451

ErhardSteinhauer and others added 2 commits January 19, 2024 12:00

Merge branch 'new-frontiers-14:master' into Goblin-Species

46858e1

restored deleted lines from speech_emote_sounds.yml

037e0f9

FoxxoTrystan reviewed Jan 19, 2024

View reviewed changes

Resources/Prototypes/_NF/Entities/Mobs/Species/goblin.yml Outdated Show resolved Hide resolved

FoxxoTrystan reviewed Jan 19, 2024

View reviewed changes

Resources/Prototypes/_NF/Entities/Mobs/Species/goblin.yml Outdated Show resolved Hide resolved

Resources/Prototypes/_NF/Entities/Mobs/Species/goblin.yml Outdated Show resolved Hide resolved

Update goblin.yml

fbba928

lowered slashing damage to 3, upped fixture radius to 0.3

Wolfking6116 reviewed Jan 19, 2024

View reviewed changes

Resources/Prototypes/_NF/Entities/Mobs/Species/goblin.yml Show resolved Hide resolved

ErhardSteinhauer added 2 commits January 19, 2024 15:21

lowered asphyxiation damage taken by gobbos, attempting to make them …

60c0a4b

…immune to rotten meat damage

now goblins aren't poisoned from eating rotten meat

e4d3c17

cooked food is poisonous for goblins now

b6c7e2e

fixed small mistake

ab7c42b

github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Apr 20, 2024

Merge branch 'master' into Goblin-Species

3db6b98

github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Apr 20, 2024

ErhardSteinhauer and others added 20 commits April 21, 2024 03:21

Merge branch 'new-frontiers-14:master' into Goblin-Species

8638a8d

nfsd at it again, fixed though

16499cd

fixes-fixes-fixes

703f747

Merge branch 'new-frontiers-14:master' into Goblin-Species

2ef14e2

Merge branch 'new-frontiers-14:master' into Goblin-Species

673afb6

Merge branch 'new-frontiers-14:master' into Goblin-Species

df1848d

Merge branch 'new-frontiers-14:master' into Goblin-Species

8bc4f1d

Merge branch 'new-frontiers-14:master' into Goblin-Species

b4a9120

Update speech_verbs.yml

dd8570f

Update chat_manager.ftl

d9ed5cc

Gabbl Gabble

71f5ec7

Sounds issues

0829846

Match DeltaV

aea9260

We did not have license for any of this files

fa0ff7f

More fixing

10d5852

Update ChatSystem.cs

b2afbc8

Merge branch 'new-frontiers-14:master' into Goblin-Species

d8eaa85

Update toys.yml

0567e62

Fixed a single missing disposal pipe

73536ec

github-actions bot added Map-Outpost Map - Outpost and removed YML labels Apr 27, 2024

Fixed folder name

c0f7d90

dvir001 approved these changes Apr 27, 2024

View reviewed changes

dvir001 merged commit 2ed0520 into new-frontiers-14:master Apr 27, 2024
14 checks passed

FrontierATC added a commit that referenced this pull request Apr 27, 2024

Automatic Changelog (#890)

74d5c51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Goblin Species #890

Goblin Species #890

ErhardSteinhauer commented Jan 19, 2024 •

edited by dvir001

Loading

github-actions bot commented Jan 19, 2024 •

edited

Loading

ErhardSteinhauer commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

FoxxoTrystan left a comment

ErhardSteinhauer commented Jan 19, 2024

FoxxoTrystan commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

Wolfking6116 commented Jan 19, 2024

FoxxoTrystan commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

GentleButter commented Jan 19, 2024

github-actions bot commented Apr 20, 2024

dvir001 left a comment

Goblin Species #890

Goblin Species #890

Conversation

ErhardSteinhauer commented Jan 19, 2024 • edited by dvir001 Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

github-actions bot commented Jan 19, 2024 • edited Loading

ErhardSteinhauer commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

FoxxoTrystan left a comment

Choose a reason for hiding this comment

ErhardSteinhauer commented Jan 19, 2024

FoxxoTrystan commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

Wolfking6116 commented Jan 19, 2024

FoxxoTrystan commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

ErhardSteinhauer commented Jan 19, 2024

GentleButter commented Jan 19, 2024

github-actions bot commented Apr 20, 2024

dvir001 left a comment

Choose a reason for hiding this comment

ErhardSteinhauer commented Jan 19, 2024 •

edited by dvir001

Loading

github-actions bot commented Jan 19, 2024 •

edited

Loading