Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alnitak (New) - Blackmarket ship with a cannon #893

Closed
wants to merge 17 commits into from

Conversation

MasterReef
Copy link

@MasterReef MasterReef commented Jan 22, 2024

About the PR

A new ship with a cannon called the ECS Alnitak! Blackmarket only.

Why / Balance

I like spaceships and guns and so if i have a spaceship and i have a gun boom! Armed Spaceship!.

Media

2024-2-27_19 06 28

  • [ X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Added the first armed ship in the game, ECS Alnitak!

@MasterReef
Copy link
Author

would love for it to be added before artillery update

SpaceStation14.sln Outdated Show resolved Hide resolved
@dvir001
Copy link
Contributor

dvir001 commented Jan 22, 2024

You still have changes on it, please download the one from this repo and push it to fix it.

@dvir001
Copy link
Contributor

dvir001 commented Jan 22, 2024

Also dont forget to move ship to Resources/Maps/_NF/Shuttles/alnitak.yml

@MasterReef
Copy link
Author

Also dont forget to move ship to Resources/Maps/_NF/Shuttles/alnitak.yml

good now?

@dvir001
Copy link
Contributor

dvir001 commented Jan 22, 2024

Also dont forget to move ship to Resources/Maps/_NF/Shuttles/alnitak.yml

good now?

image
Did you forgot to push?

@MasterReef
Copy link
Author

Also dont forget to move ship to Resources/Maps/_NF/Shuttles/alnitak.yml

good now?

image Did you forgot to push?

done and dusted

@github-actions github-actions bot removed the YML label Jan 22, 2024
@dvir001
Copy link
Contributor

dvir001 commented Jan 22, 2024

Also dont forget to move ship to Resources/Maps/_NF/Shuttles/alnitak.yml

good now?

image Did you forgot to push?

done and dusted

You are killing me

image

Also the ship shipyard yml need to point to new locations.

@MasterReef
Copy link
Author

Also dont forget to move ship to Resources/Maps/_NF/Shuttles/alnitak.yml

good now?

image Did you forgot to push?

done and dusted

You are killing me

image

Also the ship shipyard yml need to point to new locations.

Is it???? finally done??? i want to die!!!

@MasterReef
Copy link
Author

Also dont forget to move ship to Resources/Maps/_NF/Shuttles/alnitak.yml

good now?

image Did you forgot to push?

done and dusted

You are killing me

image

Also the ship shipyard yml need to point to new locations.

aaaalllsooo ive read in one of a ships script and it tells me i need to 2 paths

@dvir001
Copy link
Contributor

dvir001 commented Jan 22, 2024

I fixed the files locations for you.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 25, 2024
@dvir001 dvir001 changed the title added new black market ship with a cannon Alnitak (New) - blackmarket ship with a cannon Jan 30, 2024
@dvir001 dvir001 changed the title Alnitak (New) - blackmarket ship with a cannon Alnitak (New) - Blackmarket ship with a cannon Jan 30, 2024
@Cheackraze
Copy link
Member

i recently sped atmos up a tad and might do so again since its still not quite where I want it to be @MagnusCrowe. Theoretically, with plasma burn completed in that chamber, it should work as a giant pneumatic cannon

@MasterReef
Copy link
Author

  1. The cannon portion of the ship has 2 tiny fans where it technically needs none, due to the airlock...one at the most. Same issue with the docking ports.
  2. Your distro is all passive vents. In the event of any spacing on your ship, everything will be spaced because of this.
  3. The tiny cockpit has no scrubber, that will kill people.
  4. Ship starts off with too many canisters of oxygen and plasma.
  5. Remove the captain hardsuit locker.
  6. Remove the chemical grenade stuff and the cryobeakers.
  7. You have a sink under a light in your chem room, move one of the two please.
    image
  8. Your air alarm and APC should be rotated to face the correct direction.
  9. You might want to include an "igniter" and a proper atmospheric setup in your cannon part so nobody will need to sacrifice themselves every time you want to fire.

Lastly, I think that this ship is too dependent on the server atmos settings. IDK if it will even work with the current speed of atmos. image

In the 2nd pic, you have to put the payload in the barrel, not in the ignition chamber.

I am gonna fix these when I can.

Added a safer way to release gas from canister whilst inside the ignition chamber
Added more scrubbers

Removed tiny fans on ignition chamber airlock and docking room airlock
Removed extra burn canisters
Removed cryobeaker and etc

Fixed distro vents
@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews and removed Status: Awaiting Changes This PR has changes that need to be made before merging labels Feb 26, 2024
@MasterReef
Copy link
Author

  1. The cannon portion of the ship has 2 tiny fans where it technically needs none, due to the airlock...one at the most. Same issue with the docking ports.
  2. Your distro is all passive vents. In the event of any spacing on your ship, everything will be spaced because of this.
  3. The tiny cockpit has no scrubber, that will kill people.
  4. Ship starts off with too many canisters of oxygen and plasma.
  5. Remove the captain hardsuit locker.
  6. Remove the chemical grenade stuff and the cryobeakers.
  7. You have a sink under a light in your chem room, move one of the two please.
    image
  8. Your air alarm and APC should be rotated to face the correct direction.
  9. You might want to include an "igniter" and a proper atmospheric setup in your cannon part so nobody will need to sacrifice themselves every time you want to fire.

Lastly, I think that this ship is too dependent on the server atmos settings. IDK if it will even work with the current speed of atmos. image

Everything you told me is now fixed, if i missed some then tell me.

@MasterReef
Copy link
Author

i recently sped atmos up a tad and might do so again since its still not quite where I want it to be @MagnusCrowe. Theoretically, with plasma burn completed in that chamber, it should work as a giant pneumatic cannon

Ooooo thanks, Also do you know a way for cryogenic beakers that is filled with clf3 to explode on impact when thrown at walls from outside the station?

@MasterReef
Copy link
Author

I will be not available from 1/3 to 7/3. fyi if you guys want me to make changes.

@MasterReef
Copy link
Author

I am available now

@GreaseMonk
Copy link
Contributor

@MagnusCrowe any time to look at this soonish ?

@MagnusCrowe
Copy link
Contributor

Today in fact.

@MasterReef
Copy link
Author

Today in fact.

Not meaning to be rude but.... is 2 days after the comment still today though?

No offense intended

@MagnusCrowe
Copy link
Contributor

MagnusCrowe commented Mar 22, 2024

You need to update your branch to the latest version on Frontier master, the version you're using is missing a lot of things.

  1. You need to replace the air vent in the burn chamber with a gas injector.
  2. You don't need a disposals pipe to transport a lighter to the burn chamber, you can use a device called an igniter.
  3. Instead, you can use the disposals pipe to load the cannon without going into space probably.
  4. You could probably also use disposals to drop grenades out the back of the ship to collide with people who chase you.
  5. You need to replace the generators with the shuttle variant once your branch is up to date. These ones are automatically anchored, fueled, and running.
  6. I recommend you replace the captain's and merc's locker with pirate lockers.
  7. You can include a chem dispenser in your chemistry lab if you wish.
  8. You don't need an air sensor in rooms with powered vents and scrubbers. You only need air sensors in rooms without them, you might want to remove the one from the cargo area and add one to the burn chamber, to monitor the pressure and temperature remotely.
  9. Link your burn chamber's airlock doors so that opening one bolts the other so they both cannot be opened at the same time. That would be catastrophic.
  10. The gas mixer in your atmos setup has 30% nitrogen and 70% oxygen, the incorrect ratio. It should be about 22% oxygen and 78% nitrogen.
  11. You need to add a few emergency lights.
  12. Your substation is located on a rear wall right behind your thrusters, a prime location to become EMPed...might reduce the ships value as a contraband vessel.
  13. The ship's sell value and purchase price are really far off of eachother, was that intentional?

image

@MagnusCrowe
Copy link
Contributor

Forgot a couple things.

  1. You may want to add a fire extinguisher and a defib wall closet.
  2. I'm confused why you have a passive vent under a wall.
  3. Please route your cables under floor tiles and not under walls wherever possible.
    image

@MasterReef
Copy link
Author

You need to update your branch to the latest version on Frontier master, the version you're using is missing a lot of things.

  1. You need to replace the air vent in the burn chamber with a gas injector.
  2. You don't need a disposals pipe to transport a lighter to the burn chamber, you can use a device called an igniter.
  3. Instead, you can use the disposals pipe to load the cannon without going into space probably.
  4. You could probably also use disposals to drop grenades out the back of the ship to collide with people who chase you.
  5. You need to replace the generators with the shuttle variant once your branch is up to date. These ones are automatically anchored, fueled, and running.
  6. I recommend you replace the captain's and merc's locker with pirate lockers.
  7. You can include a chem dispenser in your chemistry lab if you wish.
  8. You don't need an air sensor in rooms with powered vents and scrubbers. You only need air sensors in rooms without them, you might want to remove the one from the cargo area and add one to the burn chamber, to monitor the pressure and temperature remotely.
  9. Link your burn chamber's airlock doors so that opening one bolts the other so they both cannot be opened at the same time. That would be catastrophic.
  10. The gas mixer in your atmos setup has 30% nitrogen and 70% oxygen, the incorrect ratio. It should be about 22% oxygen and 78% nitrogen.
  11. You need to add a few emergency lights.
  12. Your substation is located on a rear wall right behind your thrusters, a prime location to become EMPed...might reduce the ships value as a contraband vessel.
  13. The ship's sell value and purchase price are really far off of eachother, was that intentional?

image

Fixed, also the ignition chamber needs to warm up to fire, the pressure inside needs atleast 10-20k kpa.
Ship price is high cuz, you can fire a ton of ordinance in one shot and that can absolutely cut an entire ship in half. (If only chemical explosions work in places without atmos like how rpg works in space. Prob gonna add a new cannon ammo.)

Also theres wires in the in the walls of the barrel because the barrel does not have tiling.

@MasterReef
Copy link
Author

@MagnusCrowe Can you review this when you can?

@MagnusCrowe
Copy link
Contributor

MagnusCrowe commented Mar 30, 2024

@MagnusCrowe Can you review this when you can?

Today/Tonight, or maybe Sunday

@MagnusCrowe
Copy link
Contributor

You're going to need to update this branch before I do any more reviewing, sorry it's just so out of date.
See sec for example of how old this branch is.
image

@dvir001 dvir001 added Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE and removed Status: Needs Review This PR is awaiting reviews labels Apr 8, 2024
@dvir001
Copy link
Contributor

dvir001 commented Apr 8, 2024

Im closing this PR till you are doing a master pull into it,
you can reopen it or ask us here to reopen it for you.
Or you can also just move the 2 files into a new PR on updated version of your fork.

@dvir001 dvir001 closed this Apr 8, 2024
@MasterReef
Copy link
Author

I give up. This was here from January 22.

@MasterReef MasterReef deleted the Alnitak branch April 12, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants