Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidator (Update) #895

Merged
merged 10 commits into from
Jan 28, 2024

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Jan 22, 2024

About the PR

"A small vessel equipped with everything you need to make even the dirtiest ship squeaky clean (ducky slippers included).", - Shipyard.
Ship size: Small (175 tiles)
Recommended crew: 2
Cost: 31600
Power Gen Type: Uranium
Expeditions: No
IFF Console: No
Available Roles: Janitor, Pilot, Atmospheric Technician, Chemist

Why / Balance

Updated NC Liquidator in accordance with current mapping standards.

Technical details

  • Atmos rework.
  • Added Janitor Locker and JaniDrobe.
  • Added disposals.
  • Replaced PACMAN with SUPERPACMAN.
  • The Engine Room is radiation proof: added Radiation Shutters, covering windows and airlock of the engine room.
  • Enabled Pilot Job.
  • Moved ship.yml to /Maps/_NF/Shuttles/

Media

2024-1-25_12 02 06
2024-1-25_12 03 01

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog
🆑 erhardsteinhauer

  • tweak: Updated NC Liquidator to current mapping standards, simplified atmos setup.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jan 22, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 22, 2024
@MagnusCrowe MagnusCrowe added the Status: Awaiting Changes This PR has changes that need to be made before merging label Jan 25, 2024
Copy link
Contributor

@MagnusCrowe MagnusCrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a reason for a janitor ship to have a full captain and atmos hardsuit locker. Thematically, I do not think the ship should even have a captain's locker with full dress uniform with gloves, cloak, armor, etc.

Please remove the atmos locker and the captain's locker. You can replace it with an empty captain's locker and an EVA locker if you think the ship needs an EVA suit.

@ErhardSteinhauer
Copy link
Contributor Author

I do not see a reason for a janitor ship to have a full captain and atmos hardsuit locker. Thematically, I do not think the ship should even have a captain's locker with full dress uniform with gloves, cloak, armor, etc.

Please remove the atmos locker and the captain's locker. You can replace it with an empty captain's locker and an EVA locker if you think the ship needs an EVA suit.

  • Replaced captain's locker with Suit Storage Unit [EVA].
  • Replaced AtmosTech Locker with Radiation suit Storage locker.

@arimah
Copy link
Contributor

arimah commented Jan 25, 2024

Thematically, I do not think the ship should even have a captain's locker with full dress uniform with gloves, cloak, armor, etc.

I agree with this in general, but will note that some captain clothing is nice as a means of allowing ship-owning janitors to distinguish themselves from the station janitor. Personally I always wear the mantle, but YMMV.

Replaced captain's locker with Suit Storage Unit [EVA].

A captain's locker, empty or not, is nice for keeping your earnings and other valuables in.

Replaced AtmosTech Locker with Radiation suit Storage locker.

If you remove this locker (and I think it should be removed – the Liquidator is a bit overkitted for a janitor vessel), then the atmos tech job should probably go away too. I'm not sure what an atmos tech would even do, other than... drag a scrubber back and forth?

@ErhardSteinhauer
Copy link
Contributor Author

I do not see a reason for a janitor ship to have a full captain and atmos hardsuit locker. Thematically, I do not think the ship should even have a captain's locker with full dress uniform with gloves, cloak, armor, etc.

Technically, shipowner right now holds the position of captain. There isn't half-filled variant of captain's locker - it is only full or empty (and I don't think it should be changed). I personally only care about captain's mantle as a token that differentiates shipowner from other people. (And I actually forgot to map it separately. ACK!)

@ErhardSteinhauer
Copy link
Contributor Author

If you remove this locker (and I think it should be removed – the Liquidator is a bit overkitted for a janitor vessel), then the atmos tech job should probably go away too. I'm not sure what an atmos tech would even do, other than... drag a scrubber back and forth?

Most likely I will simplify the atmos setup even further in one of the next updates. When that happens atmos tech role will be removed too.

@dvir001 dvir001 changed the title NC Liquidator Update Liquidator (Update) Jan 25, 2024
@ErhardSteinhauer
Copy link
Contributor Author

Added chief researcher mantle because its color palette matches janitor's. Renamed it in chief janitor's mantle.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

RSI Diff Bot; head commit bb6413f merging into 79dfed4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Neck/Cloaks/janitor.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added
plunger-equipped-NECK Added
plunger Added

Edit: diff updated after bb6413f

@dvir001
Copy link
Contributor

dvir001 commented Jan 28, 2024

Janitor cloak with plunger slot added to replace the chief researcher mantle.

@dvir001 dvir001 self-requested a review January 28, 2024 15:46
@github-actions github-actions bot removed the Status: Awaiting Changes This PR has changes that need to be made before merging label Jan 28, 2024
@dvir001 dvir001 dismissed MagnusCrowe’s stale review January 28, 2024 15:49

The changes were made

@dvir001 dvir001 merged commit 90842e6 into new-frontiers-14:master Jan 28, 2024
13 of 14 checks passed
FrontierATC added a commit that referenced this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Sprites Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants